fix(signals): match hyphenated refactor-only no-issue rationale - #2271
fix(signals): match hyphenated refactor-only no-issue rationale#2271luciferlive112116 wants to merge 3 commits into
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-01 17:19:19 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 222 222
Lines 24661 24661
Branches 8949 8949
=======================================
Hits 23605 23605
Misses 433 433
Partials 623 623
🚀 New features to boost your workflow:
|
4d443cd to
9113e46
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
9113e46 to
7183e19
Compare
JSONbored
left a comment
There was a problem hiding this comment.
Merge conflicts:
This branch has conflicts that must be resolved
Use the [web editor](https://github.com/JSONbored/gittensory/pull/2271/conflicts) or the command line to resolve conflicts before continuing.
src/signals/engine.ts
test/unit/signals-v2.test.ts
Summary
hasClearNoIssueRationaleinsrc/signals/engine.tsis the shared definition of a clear no-issue rationale for the slop signal (#562), the public PR-panel traceability check, and the hard linked-issue gate. After #1905 (docs-only) and #1993 (test-only), refactor-only PRs using the same Conventional Commits spelling were still missed.Consequence: a refactor-only PR with no linked issue — e.g.
refactor-only: split helper— on a repo withlinkedIssueGateMode === "block"can hithardLinkedIssueBlock, fail the gate, and be auto-closed despite a valid rationale.Fix: widen the alternative to
refactor[\s-]+only, matchingrefactor only,refactor-only, and embedded body forms while leaving unrelated refactor mentions unchanged.No linked issue: this repo's
linkedIssuePolicyispreferred, and this is a small, self-evident one-token regex correctness fix parallel to the merged docs-only (#1905) and test-only (#1993) fixes.Scope
fix(signals): …).CONTRIBUTING.md; no UI/API/schema/migration changes.Validation
git diff --checknpm run typechecknpm run test:coverage— newhasClearNoIssueRationale refactor-only spellingtests cover space, hyphenated, embedded body, and negative cases.npm run test:ciIf any required check was skipped, explain why:
Safety
Notes
hasClearNoIssueRationale({ title: "refactor-only: split helper", body: "" })returnedfalse(should betrue);"Refactor queue processor"still returnsfalse.