Repository navigation
Host STM park-button in VoiceNotesBanner - #24
Merged
Merged
Conversation
Replace only the legacy Park control with a thin same-origin host for <say-to-me-park-button>, validate say-to-me-park-session, and keep the exact /park navigation shape while depending on STM pingdotgg#608/pingdotgg#605. Co-authored-by: Cursor <cursoragent@cursor.com>
Show the compact legacy Park control until the custom element registers, and keep it as a functional fallback with explicit unavailable state when the proxied park-button script cannot load or define. Co-authored-by: Cursor <cursoragent@cursor.com>
Persist failed script state, share in-flight loads, and replace stale tags on remount so a prior script error cannot leave Park stuck pending. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<say-to-me-park-button>, loading/api/say-to-me/embed/park-button.js.say-to-me-park-session(source: say-to-me-park-button,version: 1,type: park-session, matchingsessionId) before navigating./parknavigation:environmentId,threadId, optionaltitle/project/cwd/branch, thenwindow.location.assign.Dependency
Depends on Say To Me pingdotgg#608 (
feat/liftsolid-park-button-stacked, commite4571e7735f144bf035644f240bb1329b9ddef60), which itself depends on pingdotgg#605. Do not merge/enable this host until STM servesGET /embed/park-button.js.Test plan
cd apps/web && vp test run src/say-to-me/parkButton.test.ts src/say-to-me/components/chat/VoiceNotesBanner.test.tsx --passWithNoTests --project unitcd apps/server && vp test run src/say-to-me/parkButtonProxy.test.tsvp check apps/server/src/say-to-me/parkButtonProxy.test.ts apps/server/src/say-to-me/parkButtonProxy.ts apps/server/src/server.ts apps/web/src/say-to-me/SayToMeParkButtonHost.tsx apps/web/src/say-to-me/components/chat/VoiceNotesBanner.test.tsx apps/web/src/say-to-me/components/chat/VoiceNotesBanner.tsx apps/web/src/say-to-me/parkButton.test.ts apps/web/src/say-to-me/parkButton.tscd apps/web && pnpm exec tsgo --noEmit/parkquery.Made with Cursor