Skip to content

Multiple arguments have been removed from _generate_descale_mask in kagefunc #68

Open

Description

@MewX

In descaling section, the tutorial mentioned a way to use internal functions to generate credits masks:

descaled = kgf.inverse_scale(src, height=874, kernel='bicubic', b=0, c=1/2)
descaled_mask = kgf._generate_descale_mask(vsutil.get_y(core.resize.Spline36(src, descaled.width, descaled.height)), vsutil.get_y(descaled), kernel='bicubic', b=0, c=1/2)

However, the function has been reworked in: Irrational-Encoding-Wizardry/kagefunc@5c7cd67

Activity

  1. LightArrowsEXE commented on Aug 7, 2021

    @LightArrowsEXE
    Member

    I believe I rewrote that part in #56, but that was closed because I wasn't happy with my write-ups. Maybe it's time I get around to writing one I am happy with.

  2. MewX commented on Aug 8, 2021

    @MewX
    Author

    Ah, great thanks! Looking forward to it :D

    Attaching some snippets that I ended up using to compare source (8 bit), mask and filtered if that helps:

    from lvsfunc import kernels, scale
    ... ...
    
    src8 = core.text.Text(src8, "Source")
    debanded = core.text.Text(debanded, "Filtered")
    
    descaled_mask = scale.descale(dirtylines, height=855, kernel=kernels.Bicubic(), show_mask=True)
    descaled_mask = descaled_mask.resize.Point(format=debanded.format)
    descaled_mask = core.text.Text(descaled_mask, "Mask")
    comparison = core.std.Interleave([src8, descaled_mask, debanded])
    comparison.set_output()
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions