Repository navigation
fix(dart): phase 2 follow-ups from plan audit - #11
Merged
Merged
Conversation
D4: a 429 rolls the edit back and shows Dart's message in a toast; it is transient, so no persistent notice is left to dismiss. Other refusals keep their notice. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
New task text now enters the bounded draft store: it counts toward the 20-draft cap, shows the full warning with Copy and Discard it in the dialog, and is counted, copied and discarded by the Disconnect prompt. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The title field keeps typed text over a changed Dart title but says so, and follows Dart when nothing was changed. A blocked field's hint is now text a screen reader reaches (aria-describedby), the create dialog's Tags label is associated with its control, and pickers say why they are off when Dart returns no field options. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Adds the English catalog entries for this branch's new and previously hard-coded Dart copy. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…osts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…reate Comment, description and New task warnings now share one alert, one kind-aware message and one discard path (dart-draft-eviction.ts), so discarding a New task draft also drops its dialog session. A create that is submitting or may have landed is never discarded: the warning picks the next-oldest draft, and offers copy-only if nothing else is left. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the title steady while focused; useId for tags Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ording Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the final audit of Dart phase 2 (PR #10) against docs/plans/dart-phase-2.md.
Additive contract change: optional
configFailedonDartDetailEditApi(dart-detail-contracts.ts).Testing
Dart dirs: 665 files, 4368 tests passed. Typecheck web + node, changed-code quality, 4 localization checks, focus-read ratchet: green. No live Dart calls.
Review
Opus (medium) review: changes needed in round 1 (2 medium draft-loss risks), approved in round 2.
Known low items, not fixed here
🤖 Generated with Claude Code