[MAINT] Make error checks in .bat files more general#2154
Merged
ndgrigorian merged 2 commits intomasterfrom Sep 17, 2025
Merged
[MAINT] Make error checks in .bat files more general#2154ndgrigorian merged 2 commits intomasterfrom
.bat files more general#2154ndgrigorian merged 2 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_129 ran successfully. |
Collaborator
antonwolfy
reviewed
Sep 17, 2025
bld.bat wheel copy more general.bat files more general
.bat files more general.bat files more general
23ea096 to
3d7f165
Compare
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_132 ran successfully. |
antonwolfy
approved these changes
Sep 17, 2025
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes using
if %ERRORLEVEL% neq 0 exit 1in bld.bat wheel copying, which is more general thanif errorlevel 1 exit 1A similar change was suggested when adding the recipe to conda-forge