Skip to content
This repository was archived by the owner on May 17, 2026. It is now read-only.

COMP: Use modern macro for name of class - #38

Merged
thewtex merged 4 commits into
mainfrom
fix-legacy-remove
Mar 10, 2025
Merged

COMP: Use modern macro for name of class#38
thewtex merged 4 commits into
mainfrom
fix-legacy-remove

Conversation

@hjmjohnson

Copy link
Copy Markdown
Member

When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON

The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro

@dzenanz

dzenanz commented Jan 27, 2025

Copy link
Copy Markdown
Member

Among other things, this PR needs this: KitwareMedical/ITKStrain@517bb2e (#74)

@hjmjohnson
hjmjohnson force-pushed the fix-legacy-remove branch 2 times, most recently from fe8a54b to 41a0005 Compare January 28, 2025 02:59
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON

The future preferred macro should be used
│ -  itkTypeMacro
│ +  itkOverrideGetNameOfClassMacro
Set the default build package tags to v5.4.2
for capturing the ITKRemoteModuleBuildTestPackageAction
shared scripts.

This pulls the default configuration items needed
to build against ITK version v5.4.2.

@thewtex thewtex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇

@thewtex
thewtex merged commit cef0b6d into main Mar 10, 2025
@thewtex
thewtex deleted the fix-legacy-remove branch March 10, 2025 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants