Skip to content

COMP: Install a newer version of CMake on CircleCI#15

Closed
thewtex wants to merge 1 commit into
InsightSoftwareConsortium:masterfrom
thewtex:CircleCICMakeVersion
Closed

COMP: Install a newer version of CMake on CircleCI#15
thewtex wants to merge 1 commit into
InsightSoftwareConsortium:masterfrom
thewtex:CircleCICMakeVersion

Conversation

@thewtex

@thewtex thewtex commented Dec 1, 2016

Copy link
Copy Markdown
Member

Use the Python CMake wheel, which currently provides CMake 3.7.0.

This avoids the warning:

Source FileModules/Numerics/FEM/src/dsrc2c.c
Command
[+] "/usr/bin/distcc"
Directory/home/ubuntu/ITK-build/Modules/Numerics/FEM/src
Standard Error
cc1: warning: command line option '-fvisibility-inlines-hidden' is valid for
C++/ObjC++ but not for C [enabled by default]

That has been addressed on newer CMake.

Change-Id: I95c166f8b5592ad385bd165d3253788d80934f17

@thewtex
COMP: Install a newer version of CMake on CircleCI
c3938ff 
Use the Python CMake wheel, which currently provides CMake 3.7.0.

This avoids the warning:

  Source FileModules/Numerics/FEM/src/dsrc2c.c
  Command
  [+] "/usr/bin/distcc"
  Directory/home/ubuntu/ITK-build/Modules/Numerics/FEM/src
  Standard Error
  cc1: warning: command line option '-fvisibility-inlines-hidden' is valid for
  C++/ObjC++ but not for C [enabled by default]

That has been addressed on newer CMake.

Change-Id: I95c166f8b5592ad385bd165d3253788d80934f17
@blowekamp

blowekamp commented Dec 1, 2016

Copy link
Copy Markdown
Member

It looks like the problem is fixed on the dashboard:
https://open.cdash.org/buildSummary.php?buildid=4666554

As it is all green.

On the CircleCI there are no errors, warnings or test failures indicated either. But we do have the exit code:

export CTEST_OUTPUT_ON_FAILURE="1"
export DASHBOARD_MODEL="$( [[ "$CIRCLE_BRANCH" = "master" ]] && echo Continuous || echo Experimental )"
export CTEST_CONFIGURATION_TYPE="Release"
ctest -V -S "${DASHBOARD_BRANCH_DIRECTORY}/circleci.cmake"
returned exit code 255

Any ideas?

@thewtex

thewtex commented Dec 1, 2016

Copy link
Copy Markdown
Member Author

Yes, it should be exit code 0.

@blowekamp

blowekamp commented Dec 2, 2016

Copy link
Copy Markdown
Member

Yes, it should be 0 for success... But why is it 255? Hmm....

@thewtex

thewtex commented Dec 2, 2016

Copy link
Copy Markdown
Member Author

Merged via Gerrit.

@thewtex thewtex closed this Dec 2, 2016
@thewtex
thewtex deleted the CircleCICMakeVersion branch December 2, 2016 21:21
kwrobot pushed a commit to Kitware/ITK that referenced this pull request Mar 31, 2017
@fbudin69500
ENH: Update BridgeNumPy to most recent version (2017.03.27)
f7ce974 
Francois Budin (2):
      ENH: Support covariant vector images
      ENH: Wraps Symmetric Second Rank Tensors images

Matt McCormick (2):
      Merge pull request InsightSoftwareConsortium#15 from fbudin69500/SupportCovariantVector
      Merge pull request InsightSoftwareConsortium#16 from fbudin69500/WrappingSymmetricSecondRankTensorImages

Change-Id: Iad300de405e8d5659f221eaa8221bd63cbf2fef4
HastingsGreer pushed a commit to HastingsGreer/ITK that referenced this pull request Feb 18, 2019
@aylward
Merge pull request InsightSoftwareConsortium#15 from aylward/MetaConv…
710acff 
…erters

ENH: Refactoring Meta*Converter classes
@hjmjohnson hjmjohnson mentioned this pull request Apr 11, 2020
Merged
2 tasks
blowekamp added a commit to blowekamp/ITK that referenced this pull request Nov 4, 2021
@blowekamp
ENH: Update SimpleITKFilters remote module
fd67bcc 
f885603 Merge pull request InsightSoftwareConsortium#15 from blowekamp/UpdateITK5.3
ad91905 Change testing data to sha512 uploaded to data.kitware
c1ab584 Update to ITK 5.3rc2
@blowekamp blowekamp mentioned this pull request Nov 4, 2021
Merged
7 tasks
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@thewtex
Merge pull request InsightSoftwareConsortium#15 from dzenanz/NaN-fix
565e544 
Fixing appearance of Not-A-Number values when gradient is 0
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@thewtex
Merge pull request InsightSoftwareConsortium#15 from thewtex/accept-m…
da38829 
…esh-cells

BUG: Only process mesh cells when present
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@thewtex
Merge pull request InsightSoftwareConsortium#15 from jhlegarreta/Allo…
289d224 
…wBuildingExamples

ENH: Allow building examples.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@Besler
Merge pull request InsightSoftwareConsortium#15 from phcerdan/remove_…
abb483b 
…throw_upstream

COMP: Remove deprecated throw specification
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@blowekamp
Merge pull request InsightSoftwareConsortium#15 from blowekamp/Update…
f9e04f2 
…ITK5.3

Update to ITK 5.3rc2
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
@jhlegarreta
Merge pull request InsightSoftwareConsortium#15 from jhlegarreta/AddC…
51b302f 
…MakeMinimumRequiredVersion

ENH: Add CMake minimum required version.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 28, 2026
@jhlegarreta
Merge pull request InsightSoftwareConsortium#15 from jhlegarreta/FixW…
0599dc3 
…rapping

BUG: Fix wrapping.
@hjmjohnson hjmjohnson mentioned this pull request Apr 28, 2026
Closed
hjmjohnson pushed a commit that referenced this pull request Apr 30, 2026
@jhlegarreta
Merge pull request #15 from jhlegarreta/AddCMakeMinimumRequiredVersion
5587417 
ENH: Add CMake minimum required version.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 4, 2026
@thewtex
ENH: Merge pull request InsightSoftwareConsortium#15 from dzenanz/NaN…
d1d70f6 
…-fix

Fixing appearance of Not-A-Number values when gradient is 0
hjmjohnson pushed a commit that referenced this pull request May 5, 2026
@jhlegarreta
COMP: Merge pull request #15 from jhlegarreta/ReuseREADMEInfoInModule…
3cbcf12 
…CMake

DOC: Re-use `README.rst` info in `itk-module.cmake`.
hjmjohnson pushed a commit that referenced this pull request May 5, 2026
@thewtex
ENH: Merge pull request #15 from dzenanz/master
abd139a 
Clearing itk:: prefix
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@fbudin69500
ENH: Update BridgeNumPy to most recent version (2017.03.27)
8927c1d 
Francois Budin (2):
      ENH: Support covariant vector images
      ENH: Wraps Symmetric Second Rank Tensors images

Matt McCormick (2):
      Merge pull request InsightSoftwareConsortium#15 from fbudin69500/SupportCovariantVector
      Merge pull request InsightSoftwareConsortium#16 from fbudin69500/WrappingSymmetricSecondRankTensorImages

Change-Id: Iad300de405e8d5659f221eaa8221bd63cbf2fef4
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@blowekamp
ENH: Update SimpleITKFilters remote module
a78c334 
f885603 Merge pull request InsightSoftwareConsortium#15 from blowekamp/UpdateITK5.3
ad91905 Change testing data to sha512 uploaded to data.kitware
c1ab584 Update to ITK 5.3rc2
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@jhlegarreta
Merge pull request InsightSoftwareConsortium#15 from jhlegarreta/AddC…
40e963c 
…MakeMinimumRequiredVersion

ENH: Add CMake minimum required version.
hjmjohnson added a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@hjmjohnson
ENH: Merge pull request InsightSoftwareConsortium#15 from InsightSoft…
88e7004 
…wareConsortium/ITKv5_1rc2

Updates for ITKv5.2 code cleanups ... ROUND1
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 12, 2026
@fbudin69500
ENH: Update BridgeNumPy to most recent version (2017.03.27)
b79e22a 
Francois Budin (2):
      ENH: Support covariant vector images
      ENH: Wraps Symmetric Second Rank Tensors images

Matt McCormick (2):
      Merge pull request InsightSoftwareConsortium#15 from fbudin69500/SupportCovariantVector
      Merge pull request InsightSoftwareConsortium#16 from fbudin69500/WrappingSymmetricSecondRankTensorImages

Change-Id: Iad300de405e8d5659f221eaa8221bd63cbf2fef4
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 12, 2026
@blowekamp
ENH: Update SimpleITKFilters remote module
bc0e988 
f885603 Merge pull request InsightSoftwareConsortium#15 from blowekamp/UpdateITK5.3
ad91905 Change testing data to sha512 uploaded to data.kitware
c1ab584 Update to ITK 5.3rc2
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 12, 2026
@jhlegarreta
Merge pull request InsightSoftwareConsortium#15 from jhlegarreta/AddC…
ff30c7f 
…MakeMinimumRequiredVersion

ENH: Add CMake minimum required version.
hjmjohnson pushed a commit that referenced this pull request May 13, 2026
@jhlegarreta
COMP: Adapt to new multi-threading naming convention.
7b98976 
Adapt to new multi-threading naming convention. Specifically:

- Change `itk::DomainThreader::GetNumberOfThreads` to
  `itk::DomainThreader::GetNumberOfWorkUnits`.
- Change `itk::DomainThreader::SetNumberOfThreads` to
  `itk::DomainThreader::SetNumberOfWorkUnits`.

after commit:
ce15429

Addresses deprecation warnings such as:
```
/ITKParabolicMorphology/include/itkParabolicOpenCloseImageFilter.hxx:206:36:
warning: 'virtual void
itk::MultiThreaderBase::SetNumberOfThreads(itk::ThreadIdType)' is
deprecated [-Wdeprecated-declarations]
multithreader->SetNumberOfThreads(nbthreads);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
In file included from
/ITK/Modules/IO/ImageBase/include/itkImageFileReaderException.h:22:0,
from /ITK/Modules/IO/ImageBase/include/itkImageFileReader.h:20,
from /ITKParabolicMorphology/test/itkParaOpenTest.cxx:19:
/ITK/Modules/Core/Common/include/itkMultiThreaderBase.h:158:32: note:
declared here
itkLegacyMacro( virtual void SetNumberOfThreads( ThreadIdType
numberOfThreads ) )
^
/ITK/Modules/Core/Common/include/itkMacro.h:559:32: note: in definition of
macro 'itkLegacyMacro'
^~~~~~
```

Uncovered by the CI added in PR #15 and Circle CI failures in:
https://circleci.com/gh/InsightSoftwareConsortium/ITKParabolicMorphology/4?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
hjmjohnson pushed a commit that referenced this pull request May 13, 2026
@thewtex
ENH: Merge pull request #15 from jhlegarreta/AddCI
47623c7 
ENH: Add CI configuration files.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 14, 2026
@thewtex
COMP: Merge pull request InsightSoftwareConsortium#15 from jhlegarret…
07bc940 
…a/FixCMakeErrors

BUG: Fix CMake errors.
dzenanz pushed a commit that referenced this pull request May 18, 2026
@thewtex
ENH: Merge pull request #15 from thewtex/unused-variables
a6323c9 
COMP: Suppress unused numBytes numBlocks warnings
hjmjohnson pushed a commit that referenced this pull request May 19, 2026
@thewtex
ENH: Merge pull request #15 from thewtex/wrapping
2197c1f 
Wrapping
hjmjohnson pushed a commit that referenced this pull request May 20, 2026
@Besler
ENH: Merge pull request #15 from phcerdan/remove_throw_upstream
d2adab1 
COMP: Remove deprecated throw specification
dzenanz added a commit that referenced this pull request May 25, 2026
@dzenanz
STYLE: Merge pull request #15 from InsightSoftwareConsortium/fix-clan…
8f42bf1 
…g-format

This is a general version update. It still fails to compile on Windows.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 26, 2026
@thewtex
Merge pull request InsightSoftwareConsortium#15 from thewtex/accept-m…
0922c62 
…esh-cells

BUG: Only process mesh cells when present
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Jun 3, 2026
@thewtex
COMP: Merge pull request InsightSoftwareConsortium#15 from thewtex/do…
d618580 
…xygen-warnings

COMP: Doxygen file in the middle of a comment block
hjmjohnson pushed a commit that referenced this pull request Jun 3, 2026
@thewtex
ENH: Merge pull request #15 from thewtex/azure-itk-version
95403ff 
ENH: Bump Azure ITK version for ITK 5.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thewtex @blowekamp