BUG: Flawed logic for itkExceptionObject.h guards - #1048
Merged
hjmjohnson merged 1 commit intoJun 30, 2019
Merged
Conversation
The desire is that itkExceptionObject.h can only be included from itkMacro.h, but the conditional logic allowed itkExceptionObject.h to be included as long as itkMacro.h was included first. Additionally the KWSys enforced style was violated because itkExceptionObject_h was not defined at the top of the itkExceptionObject.h file.
hjmjohnson
force-pushed
the
fix-itkExceptionMacro-guards
branch
from
June 30, 2019 14:19
fad9727 to
820b7d0
Compare
dzenanz
approved these changes
Jun 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desire is that itkExceptionObject.h can only be included from
itkMacro.h, but the conditional logic allowed itkExceptionObject.h to be
included as long as itkMacro.h was included first.
Additionally the KWSys enforced style was violated because
itkExceptionObject_h was not defined at the top of the
itkExceptionObject.h file.