Conversation
…ve issues with flakeheaven pre-commit validation
…re-commit CI to try to solve the issue with flakeheaven
feat/upgrade_protobuf_version
(fix) Update OFAC JSON
…into fix/sync_dev_with_1_8_2
WalkthroughThis pull request introduces several minor updates across different configuration and dependency files. The changes include updating Python version specifications in GitHub Actions workflow, modifying the gRPC plugin version, updating dependency requirements in the project configuration, adding a new dependency, and making a small modification to an OFAC list entry. These updates aim to improve version compatibility, dependency management, and potentially address specific project requirements. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/coincurve@18.0.0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.github/workflows/pre-commit.yml(1 hunks)CHANGELOG.md(1 hunks)buf.gen.yaml(1 hunks)pyinjective/ofac.json(1 hunks)pyproject.toml(3 hunks)
✅ Files skipped from review due to trivial changes (3)
- CHANGELOG.md
- buf.gen.yaml
- pyinjective/ofac.json
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: run-tests (3.11, windows-latest)
- GitHub Check: run-tests (3.11, macos-13)
- GitHub Check: run-tests (3.10, windows-latest)
- GitHub Check: run-tests (3.9, windows-latest)
🔇 Additional comments (2)
pyproject.toml (2)
25-25: LGTM: Security-conscious version update for aiohttp.The caret version requirement for aiohttp with explicit security issue reference is a good practice.
34-34: LGTM: Flexible versioning for protobuf.The change from exact to caret version allows for compatible updates while maintaining stability.
| with: | ||
| python-version: '>=3.9 <3.12' |
There was a problem hiding this comment.
Fix Python version specification syntax for GitHub Actions.
The actions/setup-python action doesn't support version ranges. Use a specific version or a version wildcard instead.
Apply this diff to fix the syntax:
with:
- python-version: '>=3.9 <3.12'
+ python-version: '3.9' # or use '3.x' to get the latest Python 3📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| with: | |
| python-version: '>=3.9 <3.12' | |
| with: | |
| python-version: '3.9' # or use '3.x' to get the latest Python 3 |
| isort = "^5.12.0" | ||
| black = "^23.9.1" | ||
| python-dotenv = "^1.0.1" | ||
| importlib-metadata = "<5.0" |
There was a problem hiding this comment.
💡 Codebase verification
Remove explicit importlib-metadata dependency
The importlib-metadata package is unnecessary as an explicit dependency because:
- It's included in Python's standard library since Python 3.8
- No direct usage found in the codebase
- If required by development tools, it should be managed as their transitive dependency
🔗 Analysis chain
Verify the necessity and placement of importlib-metadata.
The importlib-metadata package is typically needed for Python versions <3.8, but the project requires Python ^3.9. Additionally, it's placed in dev dependencies which seems unusual.
Let's check its usage in the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for importlib.metadata or importlib_metadata usage
rg -l "import.*importlib[._]metadata" || echo "No direct imports found"
# Check if it's a dependency of other dev tools
poetry show --tree | grep -A 5 "importlib-metadata"
Length of output: 245
Script:
#!/bin/bash
# Search for build configuration files
echo "=== Build Files ==="
fd -e py -e toml -e cfg -e ini "setup|requirements|tox|pytest" --type f
# Search for alternative import patterns
echo -e "\n=== Import Patterns ==="
rg -l "from importlib[._]metadata import" || echo "No from imports found"
rg -l "importlib.*metadata" || echo "No other importlib.metadata patterns found"
# Look for test configurations that might use it
echo -e "\n=== Test Configurations ==="
fd "pytest.*\.(ini|cfg)" --type f
fd "tox\.(ini|cfg)" --type f
Length of output: 477
2 participants
PR created to sync
devbranch with the latest changes applied inmasterfor version 1.8.2Summary by CodeRabbit
Dependency Updates
aiohttpandprotobufdependency versions to more flexible requirementsimportlib-metadatadependencyConfiguration Changes
Documentation