114 improve project overview page by InfinityBowman · Pull Request #115 · InfinityBowman/corates

InfinityBowman · 2025-12-20T07:27:44Z

Summary by CodeRabbit

New Features
- Automatic PDF metadata extraction and storage, including title, authors, publication year, journal, and DOI
- New "Completed Studies" counter displayed on the overview dashboard
Improvements
- Enhanced Google Drive import workflow with improved study targeting
- Refined visibility filters for completed and reconciled checklists across views
- Updated chart heading and refined visual styling for improved clarity

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…m/InfinityBowman/corates into 114-improve-project-overview-page

coderabbitai · 2025-12-20T07:27:53Z

Walkthrough

This PR introduces PDF metadata extraction during upload and Google Drive import, propagates studyId through the import flow, refactors error handling in Google Drive integration, updates completion-status filtering for dual-reviewer studies, integrates a PDF metadata editing modal, and performs minor code simplifications and styling adjustments across multiple components.

Changes

Cohort / File(s)	Change Summary
API Error Handling `packages/web/src/api/google-drive.js`	Replaced ad-hoc error handling with centralized `parseApiError()` function in `getGoogleDriveStatus`, `disconnectGoogleDrive`, `importFromGoogleDrive`, `getGoogleDrivePickerToken`, and `connectGoogleAccount`; added diagnostic logging in `importFromGoogleDrive`.
Chart Color Adjustments `packages/web/src/components/charts/AMSTARDistribution.jsx`, `packages/web/src/components/charts/AMSTARRobvis.jsx`	Updated greyscale color map values for yes, partial yes, no, and no-ma states to uniformly darker shades; added palette source comment.
Code Simplifications `packages/web/src/components/checklist-ui/compare/NotesCompareSection.jsx`, `packages/web/src/components/project-ui/ProjectDashboard.jsx`	Consolidated `hasAnyNote` function to single-line declaration; simplified inline note-type array rendering; removed standalone comment line.
PDF Metadata Extraction & Storage `packages/web/src/stores/projectActionsStore/pdfs.js`, `packages/web/src/stores/projectActionsStore/studies.js`, `packages/web/src/components/project-ui/ProjectView.jsx`	Introduced `extractPdfMetadata()` to derive title, DOI, firstAuthor, publicationYear, and journal; integrated metadata extraction into upload and Google Drive import flows; added metadata fields to stored PDF entries with graceful error handling.
Study Completion Logic `packages/web/src/components/project-ui/completed-tab/CompletedStudyCard.jsx`, `packages/web/src/components/project-ui/completed-tab/CompletedTab.jsx`, `packages/web/src/components/project-ui/overview-tab/ChartSection.jsx`, `packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx`	Added status filter requiring both `isReconciled` and `status === 'completed'` for dual-reviewer checklists; introduced `completedStudies` computation; updated chart data filtering; changed "Quality Assessment Charts" heading to "Figures"; updated In Progress tile from blue-50 to amber-50; added Completed tile with blue-50 background.
Google Drive Import Flow `packages/web/src/components/project-ui/all-studies-tab/AllStudiesTab.jsx`, `packages/web/src/components/project-ui/google-drive/GoogleDrivePickerLauncher.jsx`, `packages/web/src/components/project-ui/google-drive/GoogleDrivePickerModal.jsx`	Added `studyId` parameter propagation through picker flow; enhanced `handleGoogleDriveImportSuccess` to accept optional `studyId` with fallback logic; updated `handlePicked` to receive and pass `studyId` as second parameter; added runtime logging.
Component Refactoring `packages/web/src/components/project-ui/all-studies-tab/study-card/StudyCard.jsx`, `packages/web/src/components/project-ui/all-studies-tab/study-card/StudyPdfSection.jsx`	Replaced internal getter functions with direct prop usage (`study`, `expanded`); integrated `EditPdfMetadataModal` with `handleEditMetadata` and `handleSaveMetadata` callbacks in StudyPdfSection.
Minor Styling & Updates `packages/web/src/components/project-ui/overview-tab/ReviewerAssignment.jsx`	Added `shadow-sm` class to outer container div.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Component as ProjectView/<br/>StudyPdfSection
    participant Store as projectActionsStore
    participant PDF as PDF Utils
    participant DOI as DOI API
    participant Firebase as Firebase

    User->>Component: Upload/Import PDF
    Component->>Store: handleUpload() or<br/>handleGoogleDriveImport()
    Store->>PDF: extractPdfMetadata(arrayBuffer)
    PDF->>PDF: extractPdfTitle()
    PDF->>PDF: extractPdfDoi()
    PDF->>DOI: fetchFromDOI(doi)
    DOI-->>PDF: {firstAuthor,<br/>publicationYear, journal}
    PDF-->>Store: {title, doi, firstAuthor,<br/>publicationYear, journal}
    Store->>Firebase: addPdfToStudy(file,<br/>pdfMetadata)
    Firebase-->>Store: PDF record created
    Store-->>Component: Success callback
    Component->>Component: Update UI
    Component-->>User: Display PDF with<br/>extracted metadata

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Metadata extraction logic in pdfs.js and studies.js: Async operations, DOI lookup integration, error handling and caching require careful validation.
Completion status filtering: Changes to dual-reviewer logic must be verified consistently across CompletedStudyCard, CompletedTab, ChartSection, and OverviewTab to prevent data inconsistency.
Google Drive import flow: StudyId propagation through multiple layers of components and callbacks needs tracing to confirm correct parameter passing.
Props refactoring in StudyCard: Replacement of getter functions with direct props requires verification that all child components and callbacks receive correct references.

Possibly related PRs

add robustness to fetching logic #93: Modifies PDF metadata extraction code and adds robustness/timeout-aware extraction during upload and import, directly overlapping with metadata extraction logic in this PR.
98 fix deleting projects for members #106: Touches the same PDF upload/import flow in packages/web/src/stores/projectActionsStore/pdfs.js, potentially requiring careful merge conflict resolution.
76 minor adjustments to studies and checklists #77: Modifies study naming conventions and fileName-based study creation logic, related to the studyName derivation introduced in ProjectView.jsx.

Poem

🐰 Metadata hops through PDF lands,
From upload streams to Firebase strands,
DOI lookups fetch the journal's name,
Completion filters sort the game,
Metadata Modal shines so bright,
Study cards now cast their light!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references improving the project overview page, but the changeset includes substantial modifications across 18 files spanning API error handling, PDF metadata extraction, checklist filtering, chart changes, and UI styling—far beyond just the overview tab.	Consider a more comprehensive title that captures the main scope, such as 'Enhance project management with PDF metadata extraction and improved checklist filtering' or 'Add PDF metadata extraction and refactor checklist completion logic'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 114-improve-project-overview-page

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2025-12-20T07:29:39Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	corates	`81072e3`	Commit Preview URL	Dec 20 2025, 07:29 AM

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (6)

packages/web/src/components/project-ui/overview-tab/ReviewerAssignment.jsx (1)

337-497: Consider consolidating ReviewerPoolSection props.

The ReviewerPoolSection component receives 9 distinct properties (title, pool, available, total, isValid, onAdd, onRemove, onUpdatePercent, onDistributeEvenly), which exceeds the recommended maximum of 1–5 props per component. While this is an internal component, consolidating this state or extracting pool management logic into a shared primitive could improve maintainability.

For example, you could create a custom hook/primitive for pool operations and pass a single pool state object, or use Solid context to provide pool callbacks globally within this component's scope.
packages/web/src/components/project-ui/google-drive/GoogleDrivePickerLauncher.jsx (1)
140-140: Remove diagnostic console.log.

This debug statement should be removed before merging to production.
Proposed fix
-      console.log('picked', picked, studyId);
       await props.onPick?.(picked, studyId);
packages/web/src/api/google-drive.js (1)
52-52: Remove diagnostic console.log.

This debug statement should be removed before merging to production.
Proposed fix
-  console.log('importing from google drive', fileId, projectId, studyId);
   const response = await fetch(`${API_BASE}/api/google-drive/import`, {
packages/web/src/components/project-ui/all-studies-tab/AllStudiesTab.jsx (1)
77-85: Consider user-facing error for missing studyId.

The guard correctly prevents passing an undefined studyId downstream, but only logs to console. Users won't know why their import failed. Consider showing a toast notification.
Proposed improvement
   const handleGoogleDriveImportSuccess = (file, studyId) => {
     // Use studyId from callback if provided, otherwise fall back to state
     const targetStudyId = studyId || googleDriveTargetStudyId();
     if (!targetStudyId) {
       console.error('No study ID available for Google Drive import');
+      showToast.error('Import Failed', 'Unable to determine target study');
       return;
     }
     projectActionsStore.pdf.handleGoogleDriveImport(targetStudyId, file);
   };
packages/web/src/components/project-ui/google-drive/GoogleDrivePickerModal.jsx (1)
30-30: Remove diagnostic console.log.

This debug statement should be removed before merging to production.
Proposed fix
       try {
-        console.log('importing from google drive', file.id, projectId(), studyId);
         setImporting(true);
packages/web/src/stores/projectActionsStore/pdfs.js (1)
47-48: Dead code: condition will never be true.

At line 37, metadata.doi is set when extractedDoi is truthy. Since we're inside the if (extractedDoi) block (line 40), metadata.doi is already assigned. The condition if (!metadata.doi) will always be false.

If the intent is to prefer refData.doi over the extracted DOI when available, the logic should be inverted. Otherwise, these lines can be removed.
Option A: Prefer refData.doi when available
-            if (!metadata.doi) metadata.doi = refData.doi || extractedDoi;
+            if (refData.doi) metadata.doi = refData.doi;
Option B: Remove dead code if extracted DOI is preferred
-            // Use extracted DOI if refData doesn't have one
-            if (!metadata.doi) metadata.doi = refData.doi || extractedDoi;

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4845668 and 81072e3.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (18)

packages/web/src/api/google-drive.js (7 hunks)
packages/web/src/components/charts/AMSTARDistribution.jsx (1 hunks)
packages/web/src/components/charts/AMSTARRobvis.jsx (1 hunks)
packages/web/src/components/checklist-ui/compare/NotesCompareSection.jsx (2 hunks)
packages/web/src/components/project-ui/ProjectDashboard.jsx (0 hunks)
packages/web/src/components/project-ui/ProjectView.jsx (1 hunks)
packages/web/src/components/project-ui/all-studies-tab/AllStudiesTab.jsx (1 hunks)
packages/web/src/components/project-ui/all-studies-tab/study-card/StudyCard.jsx (1 hunks)
packages/web/src/components/project-ui/all-studies-tab/study-card/StudyPdfSection.jsx (4 hunks)
packages/web/src/components/project-ui/completed-tab/CompletedStudyCard.jsx (1 hunks)
packages/web/src/components/project-ui/completed-tab/CompletedTab.jsx (1 hunks)
packages/web/src/components/project-ui/google-drive/GoogleDrivePickerLauncher.jsx (2 hunks)
packages/web/src/components/project-ui/google-drive/GoogleDrivePickerModal.jsx (2 hunks)
packages/web/src/components/project-ui/overview-tab/ChartSection.jsx (2 hunks)
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx (3 hunks)
packages/web/src/components/project-ui/overview-tab/ReviewerAssignment.jsx (1 hunks)
packages/web/src/stores/projectActionsStore/pdfs.js (7 hunks)
packages/web/src/stores/projectActionsStore/studies.js (2 hunks)

💤 Files with no reviewable changes (1)

packages/web/src/components/project-ui/ProjectDashboard.jsx

🧰 Additional context used

📓 Path-based instructions (11)

**/*