Skip to content

2.0.0 - #3

Open
swimtver wants to merge 3 commits into
Inceptum:2.0.0from
LimeTrading:2.0.0
Open

swimtver wants to merge 3 commits into
Inceptum:2.0.0from
LimeTrading:2.0.0

Conversation

@swimtver

Copy link
Copy Markdown

support fo https nuget feeds

{
AllowPrereleaseVersions = false,
DependencyVersion = DependencyVersion.Highest,
ApplicationRepository = @"https://artifact.finam.ru/artifactory/api/nuget/Etna.Applications",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this url is unreachable outside finam network.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, probably I should remove this test.


private static void ConfigureSupportedSslProtocols()
{
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need it?
Looks like attempt to change appserver code to adopt for obsolete or misconfigured environment...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're right, but this is the way nuget team handle issue in future versions:
NuGet.Clients/NuGet.CommandLine/Program.cs
NuGet.Core/NuGet.Common/NetworkProtocolUtility.cs

I think that's a problem with HttpClient default configuration for work with secure protocols.

@tvilkov

tvilkov commented Nov 15, 2016 •

Copy link
Copy Markdown
Contributor

To my opinion, ServicePointManager is configured on application-wide level, therefore it's not a responsibility of NugetApplication repository to configure it.
To my opinion this settings should be loaded from AppServer.exe.config and AppHost.exe.config.
There can even be standard settings for this, like for defaultProxy in system.net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants