Conversation
Tool version: clang-format version 21.1.8 Command line for reproducibility: `find . -iname "*.h" -o -iname "*.hpp" -o -iname "*.cpp" | xargs clang-format -style=file -i`
|
cscs-ci run cscs-ci-gh200, cscs-ci-mi300, cscs-ci-openmp |
|
General comment - anyone who has a branch that precedes the clang-reformat may have trouble with merge conflicts and it's a good idea to warn users that this is going to be merged so that they can get PRs merged 'before' this goes in - (or spend some time clang formatting their stuff and syncing with the new master, it can be a bit tedious/tricky to get right) |
Good point. I can see the PIF/NUFFT merge as relatively big merge in the horizon and it is better to do that before this one in order to avoid problems like the ones you mentioned. May be there is more but at least this is what I can think of at the moment. |
|
Very good point and a step by step how-to would be greatly appreciated. |
4 participants
Follow up to #479, applying clang format to all files.