fix: treat upper and lower wildcard bounds as unequal - #6884
Open
kalayciburak wants to merge 2 commits into
Open
fix: treat upper and lower wildcard bounds as unequal#6884kalayciburak wants to merge 2 commits into
kalayciburak wants to merge 2 commits into
Conversation
EqualsChecker compared wildcard bounding types but ignored isUpper, so ? super T and ? extends T compared equal. fix INRIA#6883
Collaborator
|
@kalayciburak can u fix the javadoc please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CtWildcardReference.equalsignoredisUpper, so? super Tand? extends Tcompared equal when they shared a bounding type.EqualsCheckernow comparesisUpperlike other boolean metamodel fields.fix #6883
Test plan
mvn -Dtest=EqualTest#testEqualsWildcardRespectsUpperBound test(RED before the checker change, GREEN after)mvn -Dtest=EqualTest,AssignmentsEqualsTest,GenericsTest#testWildcard,TypeReferenceTest#testClearBoundsForWildcardReference testmvn spotless:check checkstyle:check