Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/spoon/support/gui/SpoonObjectFieldsTable.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ public Object getValueAt(int rowIndex, int columnIndex) {
return null;
}

/**
* Collects non-static declared fields of {@code c} and of every
* superclass, adding them to this table model.
*
* @param c class whose instance fields should be listed; recursion
* stops when there is no superclass
*/
public void scanFields(Class<?> c) {
for (Field f : c.getDeclaredFields()) {
f.setAccessible(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,15 +190,15 @@ public void testSrcMainJava() {

// GOOD FIRST ISSUE
// ideally we want that **all** public methods are documented
// so far, we have this arbitrary limit in the condition below (32)
// so far, we have this arbitrary limit in the condition below (31)
// because it's a huge task to document everything at once
// so to contribute to Spoon, what you can do is
// 1) you lower the threshold (eg 30)
// 2) you run test `documentedTest`, it will output a list on undocumented methods
// 3) you document those methods
// 4) you run the test again to check that it passes
// 4) you commit your changes and create the corresponding pull requests
|| method.filterChildren(new TypeFilter<>(CtCodeElement.class)).list().size() > 32 // means that only large methods must be documented
|| method.filterChildren(new TypeFilter<>(CtCodeElement.class)).list().size() > 31 // means that only large methods must be documented
)) {

// OK it should be properly documented
Expand Down
Loading