Repository navigation
Add min/max validation limits for numeric design questions (#33) - #164
reyyishreyas wants to merge 2 commits into
Conversation
Carry min_value and max_value from the Google spreadsheet through the converter into the generated JSON-LD schema items, so numeric responses (e.g. sample size, number of trials/groups/factors) encode their bounds. Also document in the README that the files under inputs/tsv are the versioned backup of the spreadsheet (INCF#100).
The original run for this pull request scheduled no jobs and its logs have expired, and re-running on GitHub needs admin rights I do not have on this repository. `make validate` passes on this exact commit locally: check-json passes and all three reproschema validates report conforms. A no-op commit, made only to start a fresh workflow run.
|
The For the record, the earlier red run was not a code failure. It scheduled no jobs at all: {"total_count": 0, "jobs": []}There are no logs for it because nothing ever executed. The approval request then went unactioned for exactly 30 days — started I pushed an empty commit purely to start a fresh run. It now reports The content passes the check on that commit. I ran CI's exact command locally: So no change to the PR's files is needed — this only needs the workflow approved. One observation, offered without having confirmed it: |
Summary
Closes #33 and partially addresses #100.
Issue #33 — min/max limits for numeric questions
Numeric design questions (sample size, number of trials, groups, factors, etc.) previously had no bounds in the schema. This PR pipes
min_value/max_valuefrom the Google spreadsheet through the converter and into the generated JSON-LDresponseOptions.minValue.Changes:
inputs/tsv/design_sample.tsv: addedmin_value/max_valuecolumns and filled values for the 9 numeric design_sample itemsconvert_table/src/convert.py: TSV header now includes the new columnsconvert_table/src/utils.py: newconvert_to_optional_int()helper + reading/printing of the columns with NaN/blank handlingschemas/artemis/activities/design_and_sample/items/:minValueset (1 for counts, 0 for factors)outputs/artemis.tsv: regenerated with the new columnsIssue #100 — document spreadsheet backup
README.md: added a "Backup of the Google Spreadsheet" section explaining thatinputs/tsv/*.tsvare committed snapshots produced bymake downloadand consumed byconvert_table/src/convert.pyintooutputs/artemis.tsv.Validation
Ran
make validatelocally (fork PRs skip the CI becausevalidate.ymlonly runs on the upstream repo):pre-commit run -a check-json→ Passedreproschema validate schemas/artemis/activities→ conformsreproschema validate schemas/artemis/protocols→ conformsreproschema validate schemas/artemis/artemis_schema.jsonld→ conformsMaintainer action needed
The live Google Spreadsheet does not contain
min_value/max_valuecolumns yet. Please add them, otherwise the nextmake downloadwill overwriteinputs/tsv/design_sample.tsvand drop the limits.