Merged
Conversation
dafnapension
force-pushed
the
fix_performance_test
branch
from
04957a3 to
2f16a01
Compare
Signed-off-by: dafnapension <dafnashein@yahoo.com>
dafnapension
force-pushed
the
fix_performance_test
branch
from
2f16a01 to
12e89da
Compare
elronbandel
approved these changes
Jul 30, 2025
Member
elronbandel
left a comment
elronbandel
left a comment
There was a problem hiding this comment.
Thank you Dafna! I also like your notebook screenshot approach!
Collaborator
|
@dafnapension Shalom Dafna! Please consider reverting this change, once #1888 is merged. |
Collaborator
Author
|
Wonderful, thanks!!Your solution is much more elegant than mine!Sure, I will revert right away.Best regards,Dafna
On Thursday, July 31, 2025 at 03:13:20 PM GMT+3, Jonathan Bnayahu ***@***.***> wrote:
bnayahu left a comment (IBM/unitxt#1884)
@dafnapension Shalom Dafna! Please consider reverting this change, once #1888 is merged.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
through removal from performance evaluation of
_source_to_dataset, which generated a 403 to the dataset of recipecfpb_product_2023, although the access to this dataset is free no problem: