Repository navigation
chore: remove pii filter plugin tests - #4333
Merged
Merged
Conversation
lucarlig
marked this pull request as ready for review
April 20, 2026 10:36
lucarlig
requested review from
araujof,
crivetimihai,
jonpspri,
kevalmahajan,
madhav165 and
terylt
as code owners
April 20, 2026 10:36
lucarlig
force-pushed
the
fix/remove-pii-filter-tests
branch
from
April 20, 2026 10:38
c176a5d to
de51cf8
Compare
msureshkumar88
approved these changes
Apr 20, 2026
msureshkumar88
left a comment
msureshkumar88
left a comment
Collaborator
There was a problem hiding this comment.
PR #4333 - APPROVED ✅
PR: #4333
Title: CHORE: REMOVE PII FILTER PLUGIN TESTS
Status: ✅ APPROVED FOR MERGE
Date: 2026-04-20
Verification Results
✅ Tests Working in cpex-plugins
- Location:
cpex-plugins/plugins/rust/python-package/pii_filter/tests/test_plugin.py - Result: 26/26 tests PASSED (100% success rate, 0.28s)
- Coverage: All plugin functionality tested (initialization, prompt hooks, tool hooks, edge cases)
✅ Tests Removed from mcp-context-forge
- No PII filter test implementations remain
- Only stale
__pycache__directory (cosmetic cleanup opportunity) - Remaining references are appropriate framework/integration tests
✅ Migration Complete
- Clean separation of concerns achieved
- Test infrastructure fully functional
- No regression in test coverage
- Follows best practices for plugin externalization
Recommendation
✅ APPROVE AND MERGE
The PII filter plugin tests have been successfully migrated to cpex-plugins with 100% test pass rate. All unit tests are working in the new location, and no test implementations remain in mcp-context-forge.
Detailed review: See pr-4333-review-approval.md
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
jonpspri
force-pushed
the
fix/remove-pii-filter-tests
branch
from
April 20, 2026 20:04
de51cf8 to
7204a45
Compare
gcgoncalves
pushed a commit
that referenced
this pull request
Apr 23, 2026
* chore: remove pii filter plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: restore non-test pii filter references Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: fix restored pii config indentation Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: remove secrets detection plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: skip optional plugin packages in unit suites Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: restore manager hook unit files Signed-off-by: lucarlig <luca.carlig@ibm.com> --------- Signed-off-by: lucarlig <luca.carlig@ibm.com>
brian-hussey
pushed a commit
that referenced
this pull request
May 5, 2026
* chore: remove pii filter plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: restore non-test pii filter references Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: fix restored pii config indentation Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: remove secrets detection plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: skip optional plugin packages in unit suites Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: restore manager hook unit files Signed-off-by: lucarlig <luca.carlig@ibm.com> --------- Signed-off-by: lucarlig <luca.carlig@ibm.com> Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
msureshkumar88
pushed a commit
that referenced
this pull request
May 13, 2026
* chore: remove pii filter plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: restore non-test pii filter references Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: fix restored pii config indentation Signed-off-by: lucarlig <luca.carlig@ibm.com> * chore: remove secrets detection plugin tests Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: skip optional plugin packages in unit suites Signed-off-by: lucarlig <luca.carlig@ibm.com> * test: restore manager hook unit files Signed-off-by: lucarlig <luca.carlig@ibm.com> --------- Signed-off-by: lucarlig <luca.carlig@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pii_filterunit test package from this repoPIIFilterPluginloaded from this repoVerification
uv run pytest tests/unit/mcpgateway/plugins/framework/test_manager.py tests/unit/mcpgateway/plugins/plugins/test_init_hooks_plugins.py -qcpex_*packages (cpex_rate_limiter,cpex_retry_with_backoff,cpex_secrets_detection,cpex_url_reputation)rtk grep -n "cpex_pii_filter|PIIFilterPlugin" tests/unit tests/integrationNotes