Bh/detect secrets - #3860
Merged
Merged
Conversation
brian-hussey
added
wxo
lucarlig
previously approved these changes
Mar 25, 2026
lucarlig
left a comment
lucarlig
left a comment
Collaborator
There was a problem hiding this comment.
why no CI check, pre-commit can be skipped
Member
Author
@lucarlig Thanks, I'm looking at how to make this required for every PR now, it never activated. Remove "release-fix" tag as we're not yet ready. |
brian-hussey
dismissed stale reviews from lucarlig and madhu-mohan-jaishankar
via
March 26, 2026 12:02
0b10cee
brian-hussey
requested review from
araujof,
dima-zakharov,
jonpspri,
kevalmahajan,
madhav165 and
terylt
as code owners
March 26, 2026 17:17
brian-hussey
force-pushed
the
bh/detect-secrets
branch
from
March 26, 2026 17:19
fb89627 to
da7eb16
Compare
lucarlig
previously approved these changes
Mar 26, 2026
…cts with detect-secrets Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
brian-hussey
force-pushed
the
bh/detect-secrets
branch
from
March 27, 2026 10:16
107ef79 to
0781d21
Compare
…usly missed Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
lucarlig
approved these changes
Mar 27, 2026
madhu-mohan-jaishankar
approved these changes
Mar 27, 2026
madhu-mohan-jaishankar
left a comment
madhu-mohan-jaishankar
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. LGTM.
madhu-mohan-jaishankar
pushed a commit
that referenced
this pull request
Mar 27, 2026
* Final true up of detect-secrets work. Disabling gitleaks as it conflicts with detect-secrets Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> * True up final pieces to pass other pre-commit stages that were previously missed Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> --------- Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
msureshkumar88
pushed a commit
that referenced
this pull request
May 13, 2026
* Final true up of detect-secrets work. Disabling gitleaks as it conflicts with detect-secrets Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> * True up final pieces to pass other pre-commit stages that were previously missed Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> --------- Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
kamath-a
pushed a commit
to kamath-a/mcp-context-forge
that referenced
this pull request
Jun 26, 2026
* Final true up of detect-secrets work. Disabling gitleaks as it conflicts with detect-secrets Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> * True up final pieces to pass other pre-commit stages that were previously missed Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com> --------- Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #3859 3859
📝 Summary
This PR adds the capability to execute detect-secrets as part of pre-commit checks, in CI mode it will fail pipelines if new secrets are detected compared to the
.secrets.baselinefile.Documentation is also added to let developers know that if a secret is detected they should run
make detect-secrets-scanto update the found potential secrets followed bymake detect-secrets-auditto go through the process of attesting to the state of any potential secrets detected.Also included is a task
make detect-secret-hookwhich is the standalone equivalent of the check that will be executed in pre-commit.This PR also includes some true up required (line endings) to be able to activate the pre-commit quality gate.
🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Screenshots, design decisions, or additional context.