Add a settings to make finance2 workflow optional - #2942
Merged
Merged
Conversation
Codecov ReportBase: 80.33% // Head: 80.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
+ Coverage 80.33% 80.34% +0.01%
==========================================
Files 378 378
Lines 18369 18390 +21
==========================================
+ Hits 14757 14776 +19
- Misses 3612 3614 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
theskumar
approved these changes
Aug 11, 2022
theskumar
left a comment
theskumar
left a comment
Member
There was a problem hiding this comment.
LGTM, based on the approach. Just make sure you have covered all the edge cases.
frjo
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2918
Add INVOICE_EXTENDED_WORKFLOW setting
Make finance2 optional by the same setting.