Skip to content

Re add the stream field form for PAF - #2906

Merged
frjo merged 6 commits into
mainfrom
feature-project-approval-form
Jul 14, 2022
Merged

Re add the stream field form for PAF#2906
frjo merged 6 commits into
mainfrom
feature-project-approval-form

Conversation

@sandeepsajan0

Copy link
Copy Markdown
Member

Fixes #2904

Add description here.

@codecov

codecov Bot commented Jul 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2906 (91080a5) into main (0228ce1) will increase coverage by 0.00%.
The diff coverage is 61.79%.

❗ Current head 91080a5 differs from pull request most recent head c63fdf9. Consider uploading reports for the commit c63fdf9 to get more accurate results

@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   81.87%   81.88%           
=======================================
  Files         678      681    +3     
  Lines       24662    24750   +88     
=======================================
+ Hits        20193    20267   +74     
- Misses       4469     4483   +14     
Impacted Files Coverage Δ
hypha/apply/projects/models/__init__.py 100.00% <ø> (ø)
hypha/apply/projects/views/project.py 88.88% <20.00%> (-4.06%) ⬇️
hypha/apply/projects/admin_views.py 42.10% <42.10%> (ø)
hypha/apply/projects/admin.py 75.00% <60.00%> (-25.00%) ⬇️
hypha/apply/projects/models/project.py 92.27% <85.71%> (-0.20%) ⬇️
...100_alter_applicationbase_labbase_approval_form.py 100.00% <100.00%> (ø)
hypha/apply/funds/models/applications.py 84.75% <100.00%> (+0.10%) ⬆️
hypha/apply/funds/tests/factories/models.py 100.00% <100.00%> (ø)
hypha/apply/funds/tests/test_admin_form.py 100.00% <100.00%> (ø)
hypha/apply/projects/forms/project.py 97.39% <100.00%> (+0.02%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0228ce1...c63fdf9. Read the comment docs.

@sandeepsajan0
sandeepsajan0 marked this pull request as ready for review July 7, 2022 06:37
@frjo

frjo commented Jul 7, 2022

Copy link
Copy Markdown
Member

@sandeepsajan0 Nice! Ready to put on test?

@frjo

frjo commented Jul 7, 2022

Copy link
Copy Markdown
Member

Needs a rebase to update the migrations. Also please try to avoid out named migrations. Better with clear names.

@sandeepsajan0
sandeepsajan0 force-pushed the feature-project-approval-form branch from eb3727a to fb35a51 Compare July 8, 2022 09:13
@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Jul 14, 2022
@frjo
frjo merged commit 623a9c0 into main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re add the PAF stream field form

2 participants