teacher_st#32
Merged
Merged
Conversation
|
This pull request has been made to the wrong branch. Please review the contributing guidelines as all PRs need to be made to the We'll fix it for you this time, but please ensure you make any future PRs to the |
fixed some problems
Member
|
@Wormyy , vedel by si nam pls spravit code review? Vdaka |
jakubkoje
requested review from
jakubkoje and
julius-retzer
and removed request for
jakubkoje
March 28, 2020 22:01
| addTeachers(state, teachers) { | ||
| state.teachers = teachers; | ||
| }, | ||
| selectTeacher(state, teacher) { |
There was a problem hiding this comment.
Mozno o cosi lepsi sposob ako trackovat ktory teacher je selected by bol, ze vzdy ked selectnes nejakeho teachera tak spravis nieco ako
selectTeacher(state, selectedTeacherId) {
state.teachers = state.teachers.map(teacher => {
if (teacher.id === selectedTeacherId) {
return {...teacher, isSelected: true};
}
return {...teacher, isSelected: false};
})
}
julius-retzer
approved these changes
Mar 30, 2020
julius-retzer
left a comment
julius-retzer
left a comment
There was a problem hiding this comment.
Nechal som par komentov, ale inac to vyzera dobre, good job
Member
Napadlo ma to vyriesit este takto, co na to hovoris? |
|
moze byt 👍 |
jakubkoje
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.