Raise ValueError for off-grid nucleus in clamped_molecular_potential_Poisson#34
Merged
Merged
Conversation
…Poisson; add force=True to allow nearest-grid-point fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise error for off-grid nucleus in
clamped_molecular_potential_Poisson; addforceparameterPreviously, if a nuclear radius did not coincide with a radial grid point, the function silently issued a warning and proceeded with the nearest grid point. This is potentially dangerous: the user may not notice the warning, and the result will be inaccurate without any indication of how large the error is.
Changes
force=False), aValueErroris now raised when a nuclear radius is not a grid point, halting execution and prompting the user to either adjust their grid or explicitly opt in to the approximation.force=Truerestores the previous behaviour: aUserWarningis issued and the nearest grid point is used.force=Trueand match the new warning message.Migration
Code that previously relied on the silent fallback should add
force=Trueto the call, or ideally adjust the radial grid so that nuclear positions coincide with grid points.