Skip to content

Issue38fix#43

Merged
MehdiK merged 6 commits into
masterfrom
issue38fix
Jan 1, 2014
Merged

Issue38fix#43
MehdiK merged 6 commits into
masterfrom
issue38fix

Conversation

@MehdiK

@MehdiK MehdiK commented Dec 31, 2013

Copy link
Copy Markdown
Collaborator

@robdmoore @hazzik could you please review? Thanks

This was referenced Dec 31, 2013
@robdmoore

Copy link
Copy Markdown
Contributor

Nice! I like how you have made the new code "safer" by allowing people to opt-in. Very cool.

@robdmoore

Copy link
Copy Markdown
Contributor

re: inline data I'm happy to put in another PR since I think I know how to do it

@MehdiK

MehdiK commented Dec 31, 2013

Copy link
Copy Markdown
Collaborator Author

Cool. I hate the for-loop data injection for tests but also hate to repeat all those entries 2500 times! Looking forward to your PR.

@robdmoore

Copy link
Copy Markdown
Contributor

I'll do it after you merge this one to avoid conflicts

@robdmoore

Copy link
Copy Markdown
Contributor

This looks good to me - added a few minor comments

@MehdiK

MehdiK commented Dec 31, 2013

Copy link
Copy Markdown
Collaborator Author

Thanks mate. I fixed the issues you raised.

MehdiK added a commit that referenced this pull request Jan 1, 2014
@MehdiK MehdiK merged commit b473f0b into master Jan 1, 2014
@MehdiK MehdiK deleted the issue38fix branch January 1, 2014 06:09
@MehdiK

MehdiK commented Jan 1, 2014

Copy link
Copy Markdown
Collaborator Author

@hazzik Although this is merged, I would still really appreciate your review and will capture your notes as issues to be resolved in future changes.

@hazzik

hazzik commented Jan 1, 2014

Copy link
Copy Markdown
Contributor

@MehdiK looks good for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ToQuantity should work with plural and singular inputs Should be able to call Singularize and Pluralize on singular and plural words respectively

3 participants