Skip to content

Localised ToQuantity#285

Closed
Borzoo wants to merge 2 commits into
Humanizr:masterfrom
Borzoo:localisedToQuantity
Closed

Localised ToQuantity#285
Borzoo wants to merge 2 commits into
Humanizr:masterfrom
Borzoo:localisedToQuantity

Conversation

@Borzoo

@Borzoo Borzoo commented May 27, 2014

Copy link
Copy Markdown
Contributor

Added Farsi localization

@MehdiK

MehdiK commented May 27, 2014

Copy link
Copy Markdown
Collaborator

This is a great PR and is nicely done; but I have a conceptual issue with it. At its heart ToQuantity is just a glorified wrapper around Singularize and Pluralize which means if we want to localize anything, that would be Singularize/Pluralize methods. When that's done, ToQuantity will/should be localized as the result. Check out #197 for some background on this.

So as much as I like this PR, I have to close it. Sorry.

Thanks for the great effort. Happy to discuss further if you think this is different and should be added in.

@MehdiK MehdiK closed this May 27, 2014
@Borzoo

Borzoo commented May 28, 2014

Copy link
Copy Markdown
Contributor Author

This was an old PR (#121) that I had forgotten about. Can I work on localizing Singularize/Pluralize or is someone else working on it ?

@Borzoo Borzoo deleted the localisedToQuantity branch May 28, 2014 04:36
@MehdiK

MehdiK commented May 28, 2014

Copy link
Copy Markdown
Collaborator

Haha, cool. I now remember :)

Go for it. I don't think anyone's working on it (or the first in wins).

@Borzoo Borzoo mentioned this pull request Aug 8, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Borzoo @MehdiK