Add french localisation for NumberToWords#189
Closed
Tradioyes wants to merge 1 commit into
Closed
Conversation
Added french (fr-FR) localisation & tests for NumberToWords Localized NumberToOrdinalWordsExtension, NumberToOrdinalWordsTests and DateTimeHumanizePrecisionStrategyTests
Contributor
Author
|
Nevermind, I'm a newbie here, I close this PR to create another one properly merged with recent commits |
Contributor
|
I was about to say, the easiest way would be to pull the relevant strings out and apply to a new updated branch. This project has been moving very fast the last few days. 😃 |
Collaborator
|
Thanks for the contribution. No need to close. You should be able to fetch the latest and rebase: If rebase fails with merge conflicts: |
Contributor
Author
|
I already created PR #190 last night after closing this one. Thanks for the howto though 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateTimeHumanizePrecisionStrategyTests