T4 Template Fix / EnglishWordsConverter directly.#171
Merged
Conversation
Collaborator
|
Thanks a lot for the fix. Please rebase your work on top of upstream and also add your PR to release-notes files. |
added 2 commits
April 10, 2014 20:18
Author
|
Rebase done. Release notes are updated. What about the failing test? |
Collaborator
|
Haha, when I reviewed your code CI was still building your PR. Yeah that needs to be fixed too. Run the tests and it should pop up a diff tool showing the old approved API vs the new one. Apply your changes on the approved API (left -> right), commit and push. That should fix it. |
Author
|
Yay, all tests passed. Must check out this approval test thing, very interesting. |
MehdiK
added a commit
that referenced
this pull request
Apr 10, 2014
T4 Template Fix / EnglishWordsConverter directly.
Collaborator
|
Thanks a lot for the fix. Yeah, ApprovalTests is really awesome. You know what else is quite awesome that you should check? TestStack :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169