Skip to content

[Feature] Download audio from Youtube and others from Audio URI - #157

Closed
ProgramComputer wants to merge 91 commits into
HugoFara:devfrom
ProgramComputer:youtube-dl
Closed

ProgramComputer wants to merge 91 commits into
HugoFara:devfrom
ProgramComputer:youtube-dl

Conversation

@ProgramComputer

@ProgramComputer ProgramComputer commented Oct 8, 2023

Copy link
Copy Markdown

Built upon #156. This is a step above #156 but optional if Youtube and web extractors is too much. If either youtube-dl or ytd-dl is installed in path and set-tts(save audio to disk) in settings is set. Youtube, vimeo, and Dailymotion URLs will download to the media path.

https://github.com/ProgramComputer/lwt/blob/ab016735b89d95bcc9b36bfe6db8411e1ca2c530/INSTALL.sh#L64

is important permission-wise for this feature.

If either is installed, putting a link in text import will show a button to get subtitles.

@ProgramComputer ProgramComputer changed the title [Feature] Download audio from Youtube [Feature] Download audio from Youtube and others from Audio URI Oct 8, 2023
@ProgramComputer
ProgramComputer changed the base branch from master to dev October 9, 2023 17:55
@HugoFara HugoFara added the new-feature A new feature label Dec 27, 2023
@ProgramComputer
ProgramComputer marked this pull request as draft January 3, 2024 17:22
@HugoFara

HugoFara commented Jan 5, 2024

Copy link
Copy Markdown
Owner

Hi, I think this feature is a bit too much as it may need a lot of maintaining cost. Downloading a video don't take much time either so I don't think it's worth implementing for now, but it is a nice idea. Maybe you can show it on Discussions for those interested?

@HugoFara HugoFara closed this Jan 5, 2024
@ProgramComputer

Copy link
Copy Markdown
Author

Hi, I think this feature is a bit too much as it may need a lot of maintaining cost. Downloading a video don't take much time either so I don't think it's worth implementing for now, but it is a nice idea. Maybe you can show it on Discussions for those interested?

@HugoFara Can you leave it as a draft? This would succeed text_from_yt.php.

@HugoFara

HugoFara commented Jan 5, 2024

Copy link
Copy Markdown
Owner

Why do you need it as a draft? Moreover, due to the numerous changes since the intial PR, it will be easier for me to copy your code than merging this PR...

@ProgramComputer

Copy link
Copy Markdown
Author

Why do you need it as a draft? Moreover, due to the numerous changes since the intial PR, it will be easier for me to copy your code than merging this PR...

When will you implement the feature?

@HugoFara

HugoFara commented Jan 5, 2024

Copy link
Copy Markdown
Owner

I'm not planning on implementing it for now, I think of it as a nice extension to LWT capabilities, but I'm not reading to keep up on the maintaining cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants