Program on Java by Filip2402 · Pull Request #7 · HowProgrammingWorks/Iteration

Filip2402 · 2017-06-07T10:32:29Z

No description provided.

lidaamber

Thanks for your work, but what is the purpose of your PR? Have a look at existing PRs in this repo. The same one already exists and it requires changes very similar to your ones.

Secondly, you should format your code and add code style changes.

lidaamber · 2017-06-07T10:38:40Z

src/src/DoWhile.java

+        do {
+            System.out.println(i++);
+
+        }while (i < 10);


Code formatting.

lidaamber · 2017-06-07T10:38:54Z

src/src/For.java

+public class For {
+    public static void main(String[] args) {
+        for (int i = 0; i < 10; i++)
+        {


Code style.

lidaamber · 2017-06-07T10:39:38Z

src/src/ForEach.java

+public class ForEach {
+    public static void main(String[] args) {
+        List<Integer> list = Arrays.asList(7, 10, 1, 5, 2);
+        list.forEach(item -> System.out.println(String.format("%s, %s, %s",item,list.indexOf(item),list.toString())));


Could you split this line to fit 100 symbols in line, please?

lidaamber · 2017-06-07T10:39:50Z

src/src/ForOf.java

+public class ForOf {
+    public static void main(String[] args) {
+        for (int elem: new int[]{7, 10, 1, 5, 2})
+        {


Code style.

lidaamber · 2017-06-07T10:41:52Z

src/src/Map.java

+public class Map {
+    public static void main(String[] args) {
+
+        Function<Integer,Void> log = s -> {System.out.println(s); return null;};


Code style.

Using a forEach(), you don't need this function at all.

lidaamber · 2017-06-07T10:41:59Z

src/src/While.java

+    public static void main(String[] args) {
+        int i = 0;
+        while (i<10)
+        {


Code style.

lidaamber · 2017-06-07T10:44:36Z

src/src/Map.java

+    public static void main(String[] args) {
+
+        Function<Integer,Void> log = s -> {System.out.println(s); return null;};
+        Arrays.stream(new Integer[]{7, 10, 1, 5, 2}).map(x -> x * 2).map(log);


I'd rather use forEach() instead of map() for this example.

lidaamber

Thanks, could you format your code, please?

lidaamber · 2017-06-07T11:15:08Z

src/src/Map.java

+public class Map {
+    public static void main(String[] args) {
+
+        Function<Integer,Void> log = s -> {System.out.println(s); return null;};


Using a forEach(), you don't need this function at all.

lidaamber · 2017-06-07T11:16:32Z

src/src/ForEach.java

    public static void main(String[] args) {
        List<Integer> list = Arrays.asList(7, 10, 1, 5, 2);
-        list.forEach(item -> System.out.println(String.format("%s, %s, %s",item,list.indexOf(item),list.toString())));
+        list.forEach(item -> System.out.println(String.format("%s, %s, %s",item,list.indexOf(item),


Code formatting.

I don't undestrand, how to formatting this code?

You can have a look at Google Java Style Guide. Your IDE definitely provides tools to format code according to the selected code style. For example, if you use IntellijIdea, you can format your code using Alt + Cmd + L.

lidaamber · 2017-06-07T11:17:05Z

src/src/DoWhile.java

        do {
            System.out.println(i++);
-
        }while (i < 10);


Still needs code formatting.

lidaamber · 2017-06-07T12:02:37Z

src/src/DoWhile.java

-        do {
-            System.out.println(i++);
-        }while (i < 10);
+        do {System.out.println(i++);}while (i < 10);


Program on Java

c78be8a

lidaamber requested changes Jun 7, 2017

View reviewed changes

Program on Java

c608244

lidaamber requested changes Jun 7, 2017

View reviewed changes

Program on Java

1d85f12

lidaamber reviewed Jun 7, 2017

View reviewed changes

src/src/DoWhile.java

do {

System.out.println(i++);

}while (i < 10);

do {System.out.println(i++);}while (i < 10);

Copy link

lidaamber Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Uh oh!

Conversation

Filip2402 commented Jun 7, 2017

Uh oh!

lidaamber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidaamber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants