fix(tools): make js_execution fetch honor proxy env vars (#3273)

[LeoLin990405]

Problem

Fixes #3273 — on a host with a local proxy/VPN, js_execution can't reach the network even though CodeWhale config and the shell both have HTTP_PROXY/HTTPS_PROXY set. fetch() times out with an Undici connect error, while the shell tools reach the same URL fine.

Root cause

Node's built-in fetch (undici) ignores HTTP_PROXY/HTTPS_PROXY environment variables by default. It only honors them when NODE_USE_ENV_PROXY is set (equivalent to --use-env-proxy, Node ≥ 24). js_execution spawns node script.js inheriting CodeWhale's environment — so the proxy variables are present in the child, but Node's fetch never consults them.

Verified locally (Node 26):

# proxy env honored only with the flag → connection goes to the (dead) proxy port
$ HTTPS_PROXY=http://127.0.0.1:9 NODE_USE_ENV_PROXY=1 node -e "fetch('https://example.com').catch(e=>console.log(e.cause.code, e.cause.port))"
ECONNREFUSED 9
# without it → fetch ignores the proxy and connects directly
$ HTTPS_PROXY=http://127.0.0.1:9 node -e "fetch('https://example.com').then(r=>console.log(r.status))"
200

Fix

Default NODE_USE_ENV_PROXY=1 on the js_execution Node child so its fetch() uses the same HTTP(S)_PROXY (and honors NO_PROXY) as the rest of CodeWhale. Only defaulted when the variable is unset, so an explicit NODE_USE_ENV_PROXY=0 opt-out still wins. It's a no-op on Node < 24 (the variable is simply ignored), so it's safe across versions — the proper fix for the reporter's Node 22 would be upgrading to Node ≥ 24, but this removes the CodeWhale-side gap for every Node that supports it.

Testing

• New test execute_js_enables_env_proxy_so_fetch_honors_proxy_vars spawns the Node child and asserts it sees NODE_USE_ENV_PROXY=1 (skipped when Node is absent or the caller already set the variable).
• cargo clippy -p codewhale-tui --all-features clean; cargo test -p codewhale-tui --all-features js_execution green.

[github-actions]

Thanks @LeoLin990405 for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

[Hmbown]

Problem

Fixes #3273 — on a host with a local proxy/VPN, js_execution can't reach the network even though CodeWhale config and the shell both have HTTP_PROXY/HTTPS_PROXY set. fetch() times out with an Undici connect error, while the shell tools reach the same URL fine.

Root cause

Node's built-in fetch (undici) ignores HTTP_PROXY/HTTPS_PROXY environment variables by default. It only honors them when NODE_USE_ENV_PROXY is set (equivalent to --use-env-proxy, Node ≥ 24). js_execution spawns node script.js inheriting CodeWhale's environment — so the proxy variables are present in the child, but Node's fetch never consults them.

Verified locally (Node 26):

# proxy env honored only with the flag → connection goes to the (dead) proxy port
$ HTTPS_PROXY=http://127.0.0.1:9 NODE_USE_ENV_PROXY=1 node -e "fetch('https://example.com').catch(e=>console.log(e.cause.code, e.cause.port))"
ECONNREFUSED 9
# without it → fetch ignores the proxy and connects directly
$ HTTPS_PROXY=http://127.0.0.1:9 node -e "fetch('https://example.com').then(r=>console.log(r.status))"
200

Fix

Default NODE_USE_ENV_PROXY=1 on the js_execution Node child so its fetch() uses the same HTTP(S)_PROXY (and honors NO_PROXY) as the rest of CodeWhale. Only defaulted when the variable is unset, so an explicit NODE_USE_ENV_PROXY=0 opt-out still wins. It's a no-op on Node < 24 (the variable is simply ignored), so it's safe across versions — the proper fix for the reporter's Node 22 would be upgrading to Node ≥ 24, but this removes the CodeWhale-side gap for every Node that supports it.

Testing

• New test execute_js_enables_env_proxy_so_fetch_honors_proxy_vars spawns the Node child and asserts it sees NODE_USE_ENV_PROXY=1 (skipped when Node is absent or the caller already set the variable).
• cargo clippy -p codewhale-tui --all-features clean; cargo test -p codewhale-tui --all-features js_execution green.

This is awesome - thank you so much. I'm working on adding Tailscale comparability so things like this are increasing in value for the project in real time!!