Skip to content

feat(ci): enforce exact PPL lint frontend contracts - #5

Open
Hanyu-W wants to merge 5 commits into
ppl-lint-13-rule-cifrom
codex/ppl-lint-13-rule-ci-implementation
Open

feat(ci): enforce exact PPL lint frontend contracts#5
Hanyu-W wants to merge 5 commits into
ppl-lint-13-rule-cifrom
codex/ppl-lint-13-rule-ci-implementation

Conversation

@Hanyu-W

@Hanyu-W Hanyu-W commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Description

Builds on #4.

  • Makes the required PR corpus the 12 approved lint detectors; removes the command-suggestion syntax contract and AI action-decision assertions.
  • Keeps exact diagnostic messages and deterministic-fix assertions. expectedText is optional where the production fix does not expose a source slice.
  • Isolates detector/query execution failures: remaining contracts continue, complete error rows are written to detector-report.json, and the required check fails afterward with the precise rule/query evidence.
  • Treats frontend execution errors as infrastructure evidence in multi-version aggregation instead of suggesting detector changes.
  • Matches current OSD wiring for rex-scan-cost (enabled: false) and force-enables it only in the CI contract context.
  • Records shipping-census drift as report-only and keeps dormant contracts report-only. No OSD code change is required.

Testing

  • node --test scripts/ppl-lint/__tests__/*.test.mjs (212 passing, including a child-process fault-isolation test)
  • actionlint .github/workflows/ppl-lint-multiversion-validation.yml .github/workflows/ppl-lint-rule-validation.yml
  • node --check on all changed PPL lint modules
  • JSON parsing for all PPL lint contracts
  • git diff --check
  • Exact replay against OSD a6a535c62a1168ef65afa7d91640ec8e3eb8b52d and backend artifacts from run 30937819001: 36/36 query cases passed across 12 rules, including all three rex-scan-cost cases

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff or -s.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pin exact diagnostic, deterministic-fix, and AI-action behavior for all active schema-v4 contracts, and promote the complete 13-contract corpus to required PR validation.

Enforce the shipping census while retaining dormant detector contracts as report-only observations. Propagate frontend assertion failures through required and multi-version reports with inline annotations.

Signed-off-by: Hanyu Wei <weihanyu@amazon.com>
@Hanyu-W Hanyu-W added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant