Skip to content

feat(io-options-dialog): wire NotificationService to surface IO errors as toasts #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwardMoyse merged 1 commit into from
Jul 14, 2026
Merged

feat(io-options-dialog): wire NotificationService to surface IO errors as toasts #955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...onents/lib/components/ui-menu/io-options/io-options-dialog/io-options-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { NotificationService } from '../../../../services/notification.service';
import { type OnInit, Component, Input } from '@angular/core';
import {
CMSLoader,
Expand Down Expand Up @@ -68,6 +69,7 @@ export class IOOptionsDialogComponent implements OnInit {
constructor(
private eventDisplay: EventDisplayService,
public dialogRef: MatDialogRef<IOOptionsDialogComponent>,
private notificationService: NotificationService,
) {}

ngOnInit() {
Expand Down Expand Up @@ -121,6 +123,9 @@ export class IOOptionsDialogComponent implements OnInit {
'Could not parse JSON event file. Please ensure it is valid JSON.',
'Error',
);
this.notificationService.error(
'Could not parse JSON event file. Please ensure it is valid JSON.',
);
console.error('Error parsing JSON event file:', error);
}
};
Expand All @@ -143,6 +148,9 @@ export class IOOptionsDialogComponent implements OnInit {
'Could not parse EDM4HEP JSON file. Please ensure it is valid JSON.',
'Error',
);
this.notificationService.error(
'Could not parse EDM4HEP JSON file. Please ensure it is valid JSON.',
);
console.error('Error parsing EDM4HEP JSON file:', error);
}
};
Expand Down Expand Up @@ -260,6 +268,9 @@ export class IOOptionsDialogComponent implements OnInit {
this.eventDisplay
.getInfoLogger()
.add('Failed to load PHYSLITE file: ' + error.message, 'Error');
this.notificationService.error(
'Failed to load PHYSLITE file: ' + error.message,
);
}

this.onClose();
Expand Down Expand Up @@ -288,6 +299,7 @@ export class IOOptionsDialogComponent implements OnInit {
} catch (error) {
console.error('Error while reading zip', error);
this.eventDisplay.getInfoLogger().add('Could not read zip file', 'Error');
this.notificationService.error('Could not read zip file.');
return;
}

Expand Down Expand Up @@ -332,6 +344,7 @@ export class IOOptionsDialogComponent implements OnInit {
const errorMessage = `Failed to read file "${file.name}". The file may be corrupted, too large, or inaccessible.`;
console.error('FileReader error:', reader.error);
this.eventDisplay.getInfoLogger().add(errorMessage, 'Error');
this.notificationService.error(errorMessage);
};
reader.readAsText(file);
}
Expand All @@ -354,6 +367,7 @@ export class IOOptionsDialogComponent implements OnInit {
accepted;
console.error('Error: ' + msg);
this.eventDisplay.getInfoLogger().add(msg, 'Error');
this.notificationService.error(msg);

return false;
}
Expand Down
Loading