fix(web): resolve optimistic edit refresh race - #753
Merged
pancacake merged 1 commit intoAug 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the first edit attempt for a recently persisted non-initial user message.
loadSession()now returns its hydrated message snapshot, and the edit flow resolves an optimistic negative ID from that snapshot directly instead of immediately reading a stale React state ref.A focused regression test covers the race where the local state still contains the optimistic ID after the refresh has returned the persisted message.
Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Validation completed:
npm run test:node: 367 tests passednode ./node_modules/typescript/bin/tsc --noEmit: passedgit diff --check: passedThe repository-wide ESLint run currently reports existing errors in unrelated modules; this change adds no lint findings in the files it modifies.