Conversation
mattjala
reviewed
Feb 27, 2026
| return maxdims | ||
|
|
||
|
|
||
| def _getLayout(dset_json): |
Contributor
There was a problem hiding this comment.
It would eventually be nice to re-organize the utils to avoid having to duplicate helpers like this.
mattjala
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for forward compatibility with hsds 1.0 storage
Modify handling of default request (no parameters) so a 200 is returned (rsp is a list of top-level domains)
Important
Enhance domain request handling and layout retrieval for forward compatibility with hsds 1.0 storage, including updated tests.
domain_sn.pyto return 200 with a list of top-level domains when no parameters are provided.get_domains()indomain_sn.py.include_hrefsparameter toget_domains()to include hrefs in domain JSON.GET_Domainindomain_sn.pyto handle cases where no domain is passed, returning top-level domains.GET_Domain._getLayout()andgetLayoutClass()indsetUtil.pyandchunkUtil.pyto retrieve layout information from dataset JSON.getLayoutClass()indatanode_lib.pyto replace direct access to layout class.chunk_crawl.pyandchunkUtil.py.dsetUtil.pywhen layout information is missing or incorrect.testNullDomainindomain_test.pyto expect 200 status and validate domain list.testGetDomainindomain_test.pyto check for updated domain response structure.testGetindataset_test.pyto handle changes in layout retrieval logic.This description was created by
for a5985ec. You can customize this summary. It will automatically update as commits are pushed.