Skip to content

Codebase optimization review: TODO list + P1 bounds - #13

Draft
cursor[bot] wants to merge 2 commits into
Masterfrom
cursor/codebase-optimization-review-e128
Draft

cursor[bot] wants to merge 2 commits into
Masterfrom
cursor/codebase-optimization-review-e128

Conversation

@cursor

@cursor cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Full codebase optimization review after Phases 21–27 landed on Master.

Delivered

  • Refreshed root OPTIMIZATION_TODOS.md with open P1–P3 work for schema v12 / Wave 4+ surfaces
  • Re-applied prior review P1 bounds that never landed: terminal Arc + scrollback cap, Git kill-on-overflow / apply caps, agent line caps, browser proc/pending lock order, Windows PTY taskkill off mutex
  • New high-value fixes:
    • Bounded durable event persist queue (sync_channel) + EventBus::flush
    • Approval fingerprint + permission-rule indexes (migration 0012, schema v12)
    • Desktop transport frame byte caps + closed-panel history cap
    • Browser-service bounded NDJSON frame reader; session/recoverable caps; pending cleanup on write failure

Remaining (see OPTIMIZATION_TODOS.md)

Highest next: job writer actor, project.clone supervised job, checkpoint/file spawn_blocking + size caps, RPC HOL split, UI retention (conversation/terminal/diff), SQL pagination across Phase 21–25 list RPCs.

Tests

  • cargo test -p retcon-storage -p retcon-core -p retcon-git -p retcon-agents --lib
  • bun test test/framed.test.ts
Open in Web View Automation 

cursoragent and others added 2 commits July 18, 2026 07:45
Cap terminal scrollback behind Arc, kill/cap Git I/O including apply,
cap agent stream-json lines, fix browser proc/pending lock order,
release PTY mutex before Windows taskkill, and correct Unix transport
OwnedRead/WriteHalf types. Rebased onto Master after phases 21–27.

Co-authored-by: mtdewwolf <mtdewwolf@users.noreply.github.com>
Bound the durable event persist queue with flush, add approval
fingerprint and permission-rule indexes (schema v12), cap desktop and
browser-service NDJSON frames, limit managed browser sessions, and
rewrite OPTIMIZATION_TODOS.md for Phases 21–27.

Co-authored-by: mtdewwolf <mtdewwolf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant