Skip to content

Optimization review: TODO list + high-value bounds - #12

Draft
cursor[bot] wants to merge 2 commits into
Masterfrom
cursor/codebase-optimization-review-4331
Draft

cursor[bot] wants to merge 2 commits into
Masterfrom
cursor/codebase-optimization-review-4331

Conversation

@cursor

@cursor cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Full codebase optimization review against Master head d3e90f2 (schema v6).

  • Rewrote root OPTIMIZATION_TODOS.md with prioritized open P1–P3 work (prior file was completed-only).
  • Landed high-value bounds/hot-path fixes from the review:
    • Terminal: Arc<LiveTerminal> + capped in-memory scrollback
    • Browser: fix proc/pending async mutex lock order
    • Git: drain+kill on overflow, cap stderr, bound git apply I/O
    • Agents: capped stream-json line reader
    • Protocol: negotiate_features via HashSet
    • Terminal crate: release mutex before Windows taskkill
    • Platform: Unix OwnedReadHalf/OwnedWriteHalf after into_split()

Test plan

  • cargo test -p retcon-core -p retcon-git -p retcon-protocol -p retcon-agents -p retcon-terminal -p retcon-platform --lib

Remaining (see OPTIMIZATION_TODOS.md)

Highest next: job-persistence writer actor, event flush/bounded queue, supervised project.clone, checkpoint spawn_blocking + size caps, RPC HOL split, approval fingerprint index, desktop frame caps.

Open in Web View Automation 

cursoragent and others added 2 commits July 17, 2026 05:13
Re-audit Master head for missed bounds/hot-path work and replace the
completed-only checklist with prioritized open P1–P3 items.

Co-authored-by: mtdewwolf <mtdewwolf@users.noreply.github.com>
Cap terminal scrollback and store sessions behind Arc, fix browser
proc/pending lock order, kill/cap Git I/O on overflow, cap agent
stream-json lines, HashSet feature negotiation, release PTY mutex
before Windows taskkill, and fix Unix transport OwnedRead/WriteHalf types.

Co-authored-by: mtdewwolf <mtdewwolf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant