Open
Conversation
nbeatty-gpa
force-pushed
the
DeviceHealth
branch
from
0c013a4 to
e281cce
Compare
elwills
requested changes
Apr 2, 2026
...cations/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/DeviceIssuesPage/OpenMICIssuesPage.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+151
to
+157
| TableStyle={{ | ||
| padding: 0, width: 'calc(100%)', height: 'calc(100% - 16px)', | ||
| tableLayout: 'fixed', overflow: 'hidden', display: 'flex', flexDirection: 'column' | ||
| }} | ||
| TheadStyle={{ fontSize: 'smaller', tableLayout: 'fixed', display: 'table', width: '100%' }} | ||
| TbodyStyle={{ display: 'block', overflowY: 'auto', flex: 1 }} | ||
| RowStyle={{ display: 'table', tableLayout: 'fixed', width: '100%' }} |
Member
There was a problem hiding this comment.
How much of these styles are needed? We shouldn't specify table stylings unless they aren't part of the gpa-gemstone defaults: https://github.com/GridProtectionAlliance/gpa-gemstone/blob/master/react-table/src/Table/Table.tsx#L41-L82
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the openMIC Issues page UX by adding explicit loading and error states, and adjusts the SystemCenter openMIC meter statistics endpoint to no longer swallow upstream failures so API errors can surface to the client.
Changes:
- Add loading and server-error UI to the openMIC Issues page while statistics are being fetched.
- Remove the try/catch that previously suppressed exceptions in the openMIC meter statistics API endpoint.
- Restructure the page layout to hide the plot/table while loading or errored.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/DeviceIssuesPage/OpenMICIssuesPage.tsx | Adds LoadingScreen/ServerErrorIcon rendering and conditional layout based on request status. |
| Source/Applications/SystemCenter/Model/DeviceHealthReport.cs | Removes exception swallowing from GetOpenMICMeterStatistics, allowing failures to propagate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...cations/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/DeviceIssuesPage/OpenMICIssuesPage.tsx
Show resolved
Hide resolved
…ter/DeviceIssuesPage/OpenMICIssuesPage.tsx Co-authored-by: Erika Wills <elwills@gridprotectionalliance.org> Signed-off-by: nbeatty-gpa <nbeatty@gridprotectionalliance.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue(s)
SC-376
Description
Remove try/catch from SystemCenter's pass-through endpoint and add error and loading screens to openMIC Issues page.
How/Where to test OR Detail how it was tested
With openMIC misconfigured, navigate to the openMIC issues page for an openMIC meter.
Verify the loading screen while API request is pending, then the error message when it fails.
Verify the server error is included in the network response.
with openMIC properly configured, verify that the openMIC issues page works as expected.