Skip to content

Fix drop table chance commands#910

Merged
GregHib merged 4 commits intomainfrom
drop-tables
Mar 8, 2026
Merged

Fix drop table chance commands#910
GregHib merged 4 commits intomainfrom
drop-tables

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Mar 8, 2026

  • Fix some broken clue scroll drop rates
  • Start adding charms to drop tables

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 8.62069% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.60%. Comparing base (d87c624) to head (ad52c15).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/content/entity/player/command/DropCommands.kt 0.00% 33 Missing ⚠️
...d/gregs/voidps/engine/entity/item/drop/ItemDrop.kt 16.66% 7 Missing and 3 partials ⚠️
.../gregs/voidps/engine/entity/item/drop/DropTable.kt 0.00% 6 Missing ⚠️
...gregs/voidps/engine/entity/item/drop/DropTables.kt 50.00% 2 Missing and 1 partial ⚠️
...world/gregs/voidps/engine/entity/item/drop/Drop.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...world/gregs/voidps/engine/entity/item/drop/Drop.kt 0.00% <0.00%> (ø)
...gregs/voidps/engine/entity/item/drop/DropTables.kt 66.43% <50.00%> (-1.20%) ⬇️
.../gregs/voidps/engine/entity/item/drop/DropTable.kt 65.00% <0.00%> (-11.48%) ⬇️
...d/gregs/voidps/engine/entity/item/drop/ItemDrop.kt 52.17% <16.66%> (-38.74%) ⬇️
...tlin/content/entity/player/command/DropCommands.kt 10.23% <0.00%> (-0.42%) ⬇️
@@             Coverage Diff              @@
##               main     #910      +/-   ##
============================================
- Coverage     38.61%   38.60%   -0.02%     
- Complexity     7679     7682       +3     
============================================
  Files          1560     1561       +1     
  Lines         61939    61967      +28     
  Branches      15691    15701      +10     
============================================
+ Hits          23917    23920       +3     
- Misses        32714    32735      +21     
- Partials       5308     5312       +4     
Components Coverage Δ
Content 36.27% <0.00%> (-0.01%) ⬇️
Engine 45.32% <20.00%> (-0.08%) ⬇️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit d7bad18 into main Mar 8, 2026
5 checks passed
@GregHib GregHib deleted the drop-tables branch March 8, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant