Skip to content

Add more pickpocketting, stall and chest thieving#762

Merged
GregHib merged 9 commits intomainfrom
thieving
Sep 23, 2025
Merged

Add more pickpocketting, stall and chest thieving#762
GregHib merged 9 commits intomainfrom
thieving

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Sep 23, 2025

Closes #485

  • Add all thieving stalls

  • Add most trap chests (except rouges castle)

  • Add all pickpocket npcs

  • Add some lock picking doors

  • Add misc stealing cowbells and candles

  • Fix level up icon

  • Fix level up command

  • Fix metadata collection for deleted/renamed files

@GregHib GregHib mentioned this pull request Sep 23, 2025
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Qodana Community for JVM

9 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 9

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 31.49847% with 224 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.14%. Comparing base (188b146) to head (645cadf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/kotlin/content/skill/thieving/TrapChests.kt 36.61% 29 Missing and 16 partials ⚠️
...in/content/area/kandarin/ardougne/ArdougneDoors.kt 6.38% 44 Missing ⚠️
...e/src/main/kotlin/content/skill/thieving/Stalls.kt 42.55% 13 Missing and 14 partials ⚠️
...in/kotlin/content/area/asgarnia/entrana/Entrana.kt 12.00% 22 Missing ⚠️
...ain/kotlin/content/skill/thieving/Pickpocketing.kt 55.31% 11 Missing and 10 partials ⚠️
...gregs/voidps/engine/data/definition/data/Pocket.kt 0.00% 18 Missing ⚠️
...tlin/content/area/misthalin/lumbridge/farm/Cows.kt 0.00% 12 Missing ⚠️
...nt/area/misthalin/draynor_village/DraynorGuards.kt 23.07% 10 Missing ⚠️
...ea/fremennik_province/keldagrim/KeldagrimGuards.kt 37.50% 5 Missing ⚠️
...area/fremennik_province/rellekka/RellekkaGuards.kt 37.50% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
Files with missing lines Coverage Δ
...d/gregs/voidps/engine/entity/item/drop/ItemDrop.kt 91.66% <100.00%> (ø)
game/src/main/kotlin/content/entity/effect/Stun.kt 55.55% <100.00%> (+2.61%) ⬆️
...lin/content/entity/player/dialogue/type/LevelUp.kt 48.88% <100.00%> (+1.16%) ⬆️
game/src/main/kotlin/ContentLoader.kt 76.00% <66.66%> (+0.48%) ⬆️
.../content/area/asgarnia/port_sarim/MonkOfEntrana.kt 23.75% <0.00%> (-0.61%) ⬇️
...lin/content/entity/player/command/SkillCommands.kt 44.44% <0.00%> (ø)
.../area/fremennik_province/keldagrim/ClothesStall.kt 50.00% <50.00%> (ø)
...me/src/main/kotlin/content/skill/thieving/Stole.kt 40.00% <40.00%> (ø)
...n/content/area/kandarin/ardougne/ArdougneGuards.kt 50.00% <50.00%> (ø)
...ea/fremennik_province/keldagrim/KeldagrimGuards.kt 37.50% <37.50%> (ø)
... and 9 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #762      +/-   ##
============================================
- Coverage     35.16%   35.14%   -0.03%     
- Complexity     6057     6075      +18     
============================================
  Files          1490     1499       +9     
  Lines         60500    60770     +270     
  Branches      14716    14794      +78     
============================================
+ Hits          21275    21355      +80     
- Misses        34406    34564     +158     
- Partials       4819     4851      +32     
Components Coverage Δ
Content 32.82% <33.11%> (-0.02%) ⬇️
Engine 39.46% <5.26%> (-0.05%) ⬇️
Network 61.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit c8ecbfe into main Sep 23, 2025
5 checks passed
@GregHib GregHib deleted the thieving branch September 23, 2025 12:44
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Fix level up icon and command

* Add all thieving stalls

* Add ardougne thieving chests

* Add most trap chests

* Add ardy locked doors

* Add all pickpocketing npcs, cowbell and candle stealing

* Fix script metadata deletion

* Add gloves of silence chance changes

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thieving

1 participant