Skip to content

Allow double-clicking a gutter between panels to reset its sizing to default#4000

Merged
Keavon merged 1 commit intomasterfrom
reset-panel-sizing
Apr 3, 2026
Merged

Allow double-clicking a gutter between panels to reset its sizing to default#4000
Keavon merged 1 commit intomasterfrom
reset-panel-sizing

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 3, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Confidence score: 5/5

  • This PR appears safe to merge since the only noted issue is a naming/metadata policy concern rather than a code or runtime risk.
  • The PR title violates the allowed verb vocabulary (administrative, not user-facing), so fixable without product impact.
  • Pay close attention to frontend/src/stores/portfolio.ts - issue is a PR title enforcement rule tied to this file entry.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/src/stores/portfolio.ts">

<violation number="1" location="frontend/src/stores/portfolio.ts:5">
P1: Custom agent: **PR title enforcement**

PR title uses a leading verb ("Allow") that is not permitted by the PR title enforcement rule’s verb vocabulary. Update the title to start with an allowed verb (e.g., "Enable" or "Make").</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements tab reordering via drag-and-drop in the document panel and adds the ability to reset panel sizes by double-clicking the workspace gutters. Key changes include the addition of a ReorderDocument message in the backend to handle document list manipulation, frontend logic in Panel.svelte for drag-and-drop interactions and visual insertion markers, and persistence logic to save the new tab order. I have no feedback to provide as the review comments were purely evaluative or explanatory.

@Keavon Keavon force-pushed the reset-panel-sizing branch from 613901b to 171c052 Compare April 3, 2026 13:37
@Keavon Keavon merged commit 7077e87 into master Apr 3, 2026
9 checks passed
@Keavon Keavon deleted the reset-panel-sizing branch April 3, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant