Fix using Esc to abort box selection and wire dragging causing the graph to close#3409
Merged
Keavon merged 2 commits intoGraphiteEditor:masterfrom Dec 5, 2025
Merged
Conversation
2 tasks
wade-cheng
added a commit
to wade-cheng/Graphite
that referenced
this pull request
Nov 25, 2025
although someone already took this, whoops. GraphiteEditor#3409
Contributor
Author
|
@Keavon Hello, I believe my PR is ready for review now. |
70e7663 to
ae57479
Compare
ae57479 to
0dc0e6a
Compare
Keavon
approved these changes
Dec 5, 2025
Member
Keavon
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements proper node graph interaction aborting when pressing the Escape key (Esc) or the right mouse button (RMB). Specifically:
Note: the aborting behavior using RMB is already implemented. This PR extends that functionality to the Escape key.
Code Change
In the NodeGraphMessageHandler struct, the following fields are now public to enable access from
document_message_handler.rs:box_selection_startselection_before_pointer_downwire_in_progress_typeI made this decision since existing fields such as
drag_startis already public and used indocument_message_handler.rsin a similar way.In the
Escapekey handler indocument_message_handler.rs, I add special handling for wire dragging and box selection aborting. The logic mirrors the existing implementation for right click in node_graph_message_handler.rs (lines 760–776)..Demo Video
Google Drive link to the demo video. Unfortunately the video is too large to attach directly in the description.
Closes #2336