Merged
Conversation
Collaborator
|
Another pull request deletes the statistical testing directory. I think this should just live in the tools directory. |
Contributor
Author
|
What's the scope of the new repository? Should this live there instead? |
Collaborator
The new repository is just for stream generation and parsing. I didn't move the other statistical tests there. I just deleted them. |
etwest
requested changes
Feb 21, 2024
Collaborator
etwest
left a comment
etwest
left a comment
There was a problem hiding this comment.
Looks overall good. Just add a little comment block at the top of both of these files to say what they do and we'll merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests the probability that a column will succeed given z non-zeros.
There is independence for a given z; we repeat for statistical significance.
There is likely not independence when varying z; for performance, the data point at z is based on the same state for the data point at z-1.