Conversation
Collaborator
|
why is this an issue? aren’t we always merging into the lexicographically lower parent in cases of ties? |
Collaborator
Author
|
So the way that the code has worked so far is that if the sizes are the same then whichever endpoint is first (the src) then that is made the parent. We found it was better to "randomize" which endpoint was first so that the roots aren't clustered. This helps performance but also causes the issue I'm talking about in this pull request. Feels like this should just be solved on the DSU side rather than the caller having to worry about it. |
DanielDeLayo
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an edge case bug in the multithreaded DSU. Specifically the error occurs under the following conditions.
This will not cause the CAS to fail because thread 1 is operating on parent[x] while thread 2 is operating upon parent[y]. To solve this issue we make the ordering of edges deterministic and fixed. Thus, both threads orient the edge the same way if the sizes are identical. To "randomize" the roots, we switch whether the smaller or larger of x/y is first based upon if their sum is even/odd.