Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

Adds grpc field to liveness_probe and startup_probe to google_cloud_run_v2_service resource#1401

Merged
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-e2918f187f905d88a906b71ece64f61aafd1cdb0
Feb 27, 2023
Merged

Adds grpc field to liveness_probe and startup_probe to google_cloud_run_v2_service resource#1401
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-e2918f187f905d88a906b71ece64f61aafd1cdb0

Conversation

@modular-magician

Copy link
Copy Markdown
Contributor

This PR adds gRPC probes options for Cloud Run v2 Service resources.

The grpc fields in startup_probe and liveness_probe in the google_cloud_run_service (v1) resource were added by #6781.
The support for Cloud Run v2 Services was introduced by #6850 and released in terraform-google-provider 4.46.0, but the gRPC options for liveness probe and startup probe for the v2 services are missing.

The Go SDK v0.102.0, which this project currently uses, does not yet support the gRPC probe options for Cloud Run v2 Services. The SDK needs to be upgraded to at least v0.104.0.
So this PR waits for #6962 to be merged.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

added `template.0.containers0.liveness_probe.grpc`, `template.0.containers0.startup_probe.grpc` fields to `google_cloud_run_v2_service` resource

Derived from GoogleCloudPlatform/magic-modules#6987

…cloud_run_v2_service` resource (#6987)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested review from a team and roaks3 and removed request for a team February 27, 2023 23:49
@modular-magician modular-magician merged commit cd717ce into GoogleCloudPlatform:main Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant