Skip to content

Revert "Temporary fix for TGC tests (#9116)"#9119

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:revert-tgc-patch
Sep 28, 2023
Merged

Revert "Temporary fix for TGC tests (#9116)"#9119
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:revert-tgc-patch

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 28, 2023

Copy link
Copy Markdown
Member

This reverts commit d7c4745. And should fix broken terraform-google-conversion downstream

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 57 files changed, 5973 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2784
Skipped tests: 313
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccContainerCluster_withAddons

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withAddons[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from shuyama1 September 28, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants