Skip to content

Added google_scc_folder_custom_module resource#9024

Merged
melinath merged 8 commits into
mainfrom
b-296259216-folder
Sep 25, 2023
Merged

Added google_scc_folder_custom_module resource#9024
melinath merged 8 commits into
mainfrom
b-296259216-folder

Conversation

@melinath

@melinath melinath commented Sep 20, 2023

Copy link
Copy Markdown
Member

Part 2 of b/296259216. Part 1 is at #8993

Release Note Template for Downstream PRs (will be copied)

`google_scc_folder_custom_module`

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1706 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1706 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))
TF OiCS: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3078
Passed tests 2769
Skipped tests: 299
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountJwt|TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleFullExample|TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleBasicExample|TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleUpdate|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleBasicExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleFullExample[Debug log]
TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleBasicExample[Debug log]
TestAccSecurityCenterFolderCustomModule_sccFolderCustomModuleUpdate[Debug log]
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath

Copy link
Copy Markdown
Member Author

Failures look unrelated.

@melinath melinath requested review from a team and zli82016 and removed request for a team September 20, 2023 23:59

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants