Skip to content

allow multi-setting for classifications and excludes#8988

Merged
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
burov:allow_multi_setting
Sep 19, 2023
Merged

allow multi-setting for classifications and excludes#8988
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
burov:allow_multi_setting

Conversation

@burov

@burov burov commented Sep 18, 2023

Copy link
Copy Markdown
Member

Fixes hashicorp/terraform-provider-google#13158

If this PR is for Terraform, I acknowledge that I have:

  • run make lint on both ga and beta providers
  • run make test on both ga and beta providers
  • run testacc for osconfig service on both ga and beta providers

Release Note Template for Downstream PRs (will be copied)

osconfig: fixed no more than one setting is allowed under `patch_config.windows_update` on `google_os_config_patch_deployment`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 9 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 9 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3065
Passed tests 2765
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@burov burov force-pushed the allow_multi_setting branch from 0267b17 to 26252ee Compare September 19, 2023 11:53
@burov burov force-pushed the allow_multi_setting branch from 26252ee to 1668e73 Compare September 19, 2023 11:54
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3069
Passed tests 2770
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_os_config_patch_deployment windows_update staza should allow classifications AND excludes

3 participants