Skip to content

Added internalIpv6Prefix attribute on Subnetwork resource#8985

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
simonebruzzechesse:main
Sep 18, 2023
Merged

Added internalIpv6Prefix attribute on Subnetwork resource#8985
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
simonebruzzechesse:main

Conversation

@simonebruzzechesse

@simonebruzzechesse simonebruzzechesse commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

As per the PR title this PR adds new internalIpv6Prefix attribute available on the Subnetwork resource as per official documentation available at the following link.

This is the new PR to substitute the original #8370 since replacing the unused value is a breaking change.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added output field `internal_ipv6_prefix` to `google_compute_subnetwork` resource

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 18, 2023
@shuyama1

shuyama1 commented Sep 18, 2023

Copy link
Copy Markdown
Member

@simonebruzzechesse thanks for making the PR. Please see internal contribution page to get tests automatically run for your future PRs, so you'll able to see test results faster :)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 57 insertions(+))
Terraform Beta: Diff ( 3 files changed, 57 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3066
Passed tests 2766
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeSubnetwork_internal_ipv6

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeSubnetwork_internal_ipv6[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants