Added support for in-place update for rotation.rotation_period field in google_secret_manager_secret

[abheda-crest]

Added support for the in-place update for the rotation.rotation_period field in google_secret_manager_secret
fixes hashicorp/terraform-provider-google#13770

Release Note Template for Downstream PRs (will be copied)

secretmanager: allowed update for `rotation.rotation_period` field in `google_secret_manager_secret` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 168 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 168 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3070
Passed tests 2769
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecretManagerSecret_rotationPeriodUpdate[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccSecretManagerSecret_rotationPeriodUpdate[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

[ScottSuarez]

        Error: Error updating Secret "projects/------/secrets/tf-test-secret-e0pv0ufn0u": Patch "https://secretmanager.googleapis.com/v1/projects/-------/secrets/tf-test-secret-e0pv0ufn0u?alt=json&updateMask=topics%2Crotation": Requested interaction not found
        
          with google_secret_manager_secret.secret-basic,
          on terraform_plugin_test.tf line 14, in resource "google_secret_manager_secret" "secret-basic":
          14: resource "google_secret_manager_secret" "secret-basic" {

[abheda-crest]

@ScottSuarez TestAccSecretManagerSecret_rotationPeriodUpdate was passing locally. Also, according to the comment, this test passed in recording mode but failed in replaying mode due to non-determinism or randomness. I suspect that this might be due to passing a generated timestamp. To confirm this, I've updated the test to pass a static timestamp.

[ScottSuarez]

Ah, yep that tracks !! Sorry for the confusion. I should of looked a little closer! Lets check the rerun.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 167 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 167 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3076
Passed tests 2776
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecretManagerSecret_rotationPeriodUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecretManagerSecret_rotationPeriodUpdate[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[abheda-crest]

@ScottSuarez Could you please review the changes?