Promote tpu-topology to GA#8953
Conversation
|
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 90 insertions(+), 52 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
|
Rerun these tests in REPLAYING mode to catch issues
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
Hi! Yes, please refer to internal bug 291813193 comment 4 and 5 for proof of acceptance test working and passing local testing. I produced terraform-provider-google then commented out t.Skip() and ran the acceptance test. |
|
Don't think the failing test is related. /gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 90 insertions(+), 52 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
shuyama1
left a comment
There was a problem hiding this comment.
Thank you for working on it!
The test is not working in our testing environment so skipped it completely (VRC + nightly). More context at hashicorp/terraform-provider-google#15254 (comment)
For GA test for this PR, it's confirmed passing locally. see b/291813193 for evidence
Promote support for GKE 1VM TPU.
tpu_topologyfield to GA in NodePool schema to support TPU machines.Extension of /pull/8271
Fixes hashicorp/terraform-provider-google/issues/15837
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)