Added read timeout to bigtable instance#8948
Conversation
|
Hello! I am a robot. It looks like you are a: @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 6 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccDataprocClusterIamPolicy|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
NickElliot
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the clean update :)
|
One question though: does this fix the issue (hashicorp/terraform-provider-google#14565) you had linked? If so could you move the link to the top and format it as "Fixes hashicorp/terraform-provider-google#14565" |
Sadly, no. It's the small part I figured out quickly. Will continue working on the whole fix after this is merged. |
hashicorp/terraform-provider-google#14565
Release Note Template for Downstream PRs (will be copied)