Skip to content

Added read timeout to bigtable instance#8948

Merged
NickElliot merged 1 commit into
GoogleCloudPlatform:mainfrom
ron-gal:read_timeout
Sep 14, 2023
Merged

Added read timeout to bigtable instance#8948
NickElliot merged 1 commit into
GoogleCloudPlatform:mainfrom
ron-gal:read_timeout

Conversation

@ron-gal

@ron-gal ron-gal commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

hashicorp/terraform-provider-google#14565

Release Note Template for Downstream PRs (will be copied)

bigtable: added a read timeout to `google_bigtable_instance`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 2 deletions(-))

@ron-gal ron-gal marked this pull request as ready for review September 13, 2023 21:30
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3037
Passed tests 2734
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataTable_bigtable|TestAccDataprocClusterIamPolicy|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample[Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm[Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clean update :)

@NickElliot

Copy link
Copy Markdown
Contributor

One question though: does this fix the issue (hashicorp/terraform-provider-google#14565) you had linked? If so could you move the link to the top and format it as "Fixes hashicorp/terraform-provider-google#14565"

@ron-gal

ron-gal commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

One question though: does this fix the issue (hashicorp/terraform-provider-google#14565) you had linked? If so could you move the link to the top and format it as "Fixes hashicorp/terraform-provider-google#14565"

Sadly, no. It's the small part I figured out quickly. Will continue working on the whole fix after this is merged.

@NickElliot NickElliot merged commit 27428b5 into GoogleCloudPlatform:main Sep 14, 2023
@ron-gal ron-gal deleted the read_timeout branch September 14, 2023 22:45
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants